Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 581923002: Experimental launcher: Switcher buttons are larger and centered. (Closed)

Created:
6 years, 3 months ago by Matt Giuca
Modified:
6 years, 3 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@ares-switcher-button-cropping
Project:
chromium
Visibility:
Public.

Description

Experimental launcher: Switcher buttons are larger and centered. Buttons are now 39x39, giving them bigger click/tap target zones, spacing them further apart, and centering them within the switcher area. The actual image sizes have not changed. Moved the separator line up 1px to make room and to match the mocks. Also added a new test of the exact dimensions of the app launcher, to make sure we don't accidentally enlarge the window (which would have been easy to accidentally do in this patch). BUG=411775 Committed: https://crrev.com/2177f5fd17f39f4602d9cc39477cb3244bfaba62 Cr-Commit-Position: refs/heads/master@{#295934}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase onto CL 583843003. #

Patch Set 4 : Move separator up and add sanity test. #

Total comments: 2

Patch Set 5 : Fix comment. #

Patch Set 6 : Rebase. #

Patch Set 7 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M ui/app_list/views/app_list_background.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_view_unittest.cc View 1 2 3 4 1 chunk +20 lines, -5 lines 0 comments Download
M ui/app_list/views/contents_switcher_view.cc View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Matt Giuca
6 years, 3 months ago (2014-09-18 05:21:19 UTC) #4
Matt Giuca
PTAL.
6 years, 3 months ago (2014-09-22 03:36:57 UTC) #5
calamity
lgtm https://codereview.chromium.org/581923002/diff/100001/ui/app_list/views/app_list_view_unittest.cc File ui/app_list/views/app_list_view_unittest.cc (right): https://codereview.chromium.org/581923002/diff/100001/ui/app_list/views/app_list_view_unittest.cc#newcode250 ui/app_list/views/app_list_view_unittest.cc:250: // NOTE: Height should exceed 402, because otherwise ...
6 years, 3 months ago (2014-09-22 03:50:45 UTC) #6
Matt Giuca
https://codereview.chromium.org/581923002/diff/100001/ui/app_list/views/app_list_view_unittest.cc File ui/app_list/views/app_list_view_unittest.cc (right): https://codereview.chromium.org/581923002/diff/100001/ui/app_list/views/app_list_view_unittest.cc#newcode250 ui/app_list/views/app_list_view_unittest.cc:250: // NOTE: Height should exceed 402, because otherwise there ...
6 years, 3 months ago (2014-09-22 04:00:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581923002/160001
6 years, 3 months ago (2014-09-22 06:48:28 UTC) #9
commit-bot: I haz the power
Committed patchset #7 (id:160001) as a0033e6a013368488dac7e8bbeafbbebf9c689a8
6 years, 3 months ago (2014-09-22 07:32:52 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 07:33:43 UTC) #11
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/2177f5fd17f39f4602d9cc39477cb3244bfaba62
Cr-Commit-Position: refs/heads/master@{#295934}

Powered by Google App Engine
This is Rietveld 408576698