Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 581913003: PDF Viewer - Add keyboard shortcuts for rotation (Closed)

Created:
6 years, 3 months ago by Nikhil
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PDF Viewer - Add keyboard shortcuts for rotation Currently there are no keyboard shortcuts to rotate pdf documents. This patch adds the following keyboard shortcuts to rotate pdf documents : Rotate counterclockwise : Control + [ Rotate clockwise : Control + ] BUG=111232 Committed: https://crrev.com/cb0114633bb478c4636126d9d2ed87c1580e9ff8 Cr-Commit-Position: refs/heads/master@{#295757}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback (nit fix) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
M pdf/instance.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M pdf/out_of_process_instance.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nikhil
PTAL at my changes to add keyboard shortcuts to rotate pdf documents. If you've any ...
6 years, 3 months ago (2014-09-18 05:31:26 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/581913003/diff/1/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/581913003/diff/1/chrome/browser/resources/pdf/pdf.js#newcode261 chrome/browser/resources/pdf/pdf.js:261: case 219: // left bracket. nit: 2 spaces ...
6 years, 3 months ago (2014-09-18 20:41:07 UTC) #3
Nikhil
Rebase and nit fix done. PTAL. Thanks! https://codereview.chromium.org/581913003/diff/1/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/581913003/diff/1/chrome/browser/resources/pdf/pdf.js#newcode261 chrome/browser/resources/pdf/pdf.js:261: case 219: ...
6 years, 3 months ago (2014-09-19 14:12:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581913003/20001
6 years, 3 months ago (2014-09-19 18:35:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b85aa171dfcb8da516e87d30e1632e61b0fdfba4
6 years, 3 months ago (2014-09-19 19:16:24 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 19:17:30 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb0114633bb478c4636126d9d2ed87c1580e9ff8
Cr-Commit-Position: refs/heads/master@{#295757}

Powered by Google App Engine
This is Rietveld 408576698