Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 581903002: [Cast] Fix referenced_frame_ids emitted by Vp8Encoder, with massive test clean-up. (Closed)

Created:
6 years, 3 months ago by miu
Modified:
6 years, 3 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Cast] Fix referenced_frame_ids emitted by Vp8Encoder, with massive test clean-up. The referenced_frame_ids set by Vp8Encoder were wrong in two ways: 1) A recent change introduced an off-by-one error. 2) Math was being done with results stored in a uint8 variable, which was causing the upper 24 bits to be stripped. Added VideoEncoderImplTest.GeneratesKeyFrameThenOnlyDeltaFrames test to prevent future regressions. In addition, a lot of unit test code clean-up was done to beef-up existing testing while also removing useless tests. Committed: https://crrev.com/738b28e4720cf936825deaf4303fdb085c9e0be4 Cr-Commit-Position: refs/heads/master@{#295493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -123 lines) Patch
M media/cast/receiver/video_decoder_unittest.cc View 3 chunks +7 lines, -1 line 0 comments Download
M media/cast/sender/video_encoder_impl_unittest.cc View 7 chunks +61 lines, -120 lines 0 comments Download
M media/cast/sender/vp8_encoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
miu
hubbe: PTAL. Fixed as discussed earlier today, with testing to prevent future breakage.
6 years, 3 months ago (2014-09-18 02:12:36 UTC) #2
hubbe
lgtm
6 years, 3 months ago (2014-09-18 17:28:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581903002/1
6 years, 3 months ago (2014-09-18 17:29:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 020596749116bcb69491bedafdb9f5eef72edc08
6 years, 3 months ago (2014-09-18 17:55:27 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 17:56:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/738b28e4720cf936825deaf4303fdb085c9e0be4
Cr-Commit-Position: refs/heads/master@{#295493}

Powered by Google App Engine
This is Rietveld 408576698