Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 581853003: App list: The line under folder headings has a fixed margin. (Closed)

Created:
6 years, 3 months ago by Matt Giuca
Modified:
6 years, 3 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

App list: The line under folder headings has a fixed margin. Previously, it had a fixed width, causing it to be very short on the wider app list window style. Now it extends (almost) all the way to the edge regardless of the app list's width. BUG=415461 Committed: https://crrev.com/2cf06c31177287c9a1aecdf5b5ac6e2148215bf2 Cr-Commit-Position: refs/heads/master@{#295697}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use insets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M ui/app_list/views/folder_header_view.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Matt Giuca
6 years, 3 months ago (2014-09-18 07:19:36 UTC) #2
calamity
lgtm https://codereview.chromium.org/581853003/diff/1/ui/app_list/views/folder_header_view.cc File ui/app_list/views/folder_header_view.cc (right): https://codereview.chromium.org/581853003/diff/1/ui/app_list/views/folder_header_view.cc#newcode197 ui/app_list/views/folder_header_view.cc:197: rect.set_width(rect.width() - kBottomSeparatorPadding * 2); Use Rect::Inset().
6 years, 3 months ago (2014-09-19 09:56:17 UTC) #3
Matt Giuca
https://codereview.chromium.org/581853003/diff/1/ui/app_list/views/folder_header_view.cc File ui/app_list/views/folder_header_view.cc (right): https://codereview.chromium.org/581853003/diff/1/ui/app_list/views/folder_header_view.cc#newcode197 ui/app_list/views/folder_header_view.cc:197: rect.set_width(rect.width() - kBottomSeparatorPadding * 2); On 2014/09/19 09:56:17, calamity ...
6 years, 3 months ago (2014-09-19 09:58:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581853003/20001
6 years, 3 months ago (2014-09-19 09:59:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/15968)
6 years, 3 months ago (2014-09-19 11:11:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581853003/20001
6 years, 3 months ago (2014-09-19 13:14:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a390d5455d34439a60c187f5d470d29e523e5327
6 years, 3 months ago (2014-09-19 13:45:05 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 13:45:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2cf06c31177287c9a1aecdf5b5ac6e2148215bf2
Cr-Commit-Position: refs/heads/master@{#295697}

Powered by Google App Engine
This is Rietveld 408576698