Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1799)

Issue 581853002: Remove deprecated 'title' manifest attribute. (Closed)

Created:
6 years, 3 months ago by garykac
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated 'title' manifest attribute from unittests. BUG= Committed: https://crrev.com/d690ae96c6e1c84d0503e72d08e842ccf02c0909 Cr-Commit-Position: refs/heads/master@{#295817}

Patch Set 1 #

Patch Set 2 : sync #

Messages

Total messages: 19 (7 generated)
garykac
6 years, 3 months ago (2014-09-18 22:11:48 UTC) #2
jackhou1
lgtm
6 years, 3 months ago (2014-09-18 23:03:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581853002/1
6 years, 3 months ago (2014-09-18 23:36:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/16950) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/5564) android_chromium_gn_compile_dbg ...
6 years, 3 months ago (2014-09-18 23:44:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581853002/20001
6 years, 3 months ago (2014-09-19 21:19:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12274) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11485)
6 years, 3 months ago (2014-09-19 21:35:40 UTC) #11
garykac
+rockot for OWNERS
6 years, 3 months ago (2014-09-19 21:47:40 UTC) #13
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-19 22:59:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581853002/20001
6 years, 3 months ago (2014-09-19 23:51:06 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7ff91ffbb31c8774141a6b06b3c3847041a5b880
6 years, 3 months ago (2014-09-19 23:58:03 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 519dcd50e96387f9665a15e149d78ad468ba5e06
6 years, 3 months ago (2014-09-19 23:58:32 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 23:58:58 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d690ae96c6e1c84d0503e72d08e842ccf02c0909
Cr-Commit-Position: refs/heads/master@{#295817}

Powered by Google App Engine
This is Rietveld 408576698