Updated alternative data reduction proxy UI

Updated alternative data reduction proxy UI

Adds a link to the infobar and updates strings.

BUG=383988
Committed: https://crrev.com/35df204ba23a4d5c13b693bac9c4dd583ce36064
Cr-Commit-Position: refs/heads/master@{#295516}

[bengr, 2014-09-18 00:04:10]

bengr@chromium.org changed reviewers:
+ marq@chromium.org, tedchoc@chromium.org

[bengr, 2014-09-18 00:04:11]

tedchoc: *android*
marq: *spdyproxy*

[bengr, 2014-09-18 00:04:24]

Patchset #1 (id:1) has been deleted

[Ted C, 2014-09-18 00:40:21]

https://codereview.chromium.org/581833002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java
(right):

https://codereview.chromium.org/581833002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:54:

remove this extra blank line

https://codereview.chromium.org/581833002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:63:
layout.setButtons(sLinkText, null, null);
I think you can just use setButtons(sLinkText, null);

https://codereview.chromium.org/581833002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java
(right):

https://codereview.chromium.org/581833002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java:17:
* @param webContents The {@link WebContents} in which to launh the {@link
InfoBar}.
want to take another stab at this spelling :-)

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.cc
(right):

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.cc:66: return
false;
does something else handle closing this?

Just wondering why not returning true

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/ui/androi...
File chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h (right):

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/ui/androi...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h:16:
Launch(JNIEnv* env, jclass, jobject jweb_contents, jstring jlink_url);
Wrap the params instead of after void.

[marq (ping after 24h), 2014-09-18 17:45:46]

spdyproxy/ LGTM modulo Ted's comment.

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h
(right):

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:19: // and
a link, and is used only by an Android field trial.
Is this still true? If not -- if iOS support is needed -- then please file a
bug.

[bengr, 2014-09-18 18:01:15]

https://codereview.chromium.org/581833002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java
(right):

https://codereview.chromium.org/581833002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:54:

On 2014/09/18 00:40:21, Ted C wrote:
> remove this extra blank line

Done.

https://codereview.chromium.org/581833002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java:63:
layout.setButtons(sLinkText, null, null);
On 2014/09/18 00:40:21, Ted C wrote:
> I think you can just use setButtons(sLinkText, null);

Done.

https://codereview.chromium.org/581833002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java
(right):

https://codereview.chromium.org/581833002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java:17:
* @param webContents The {@link WebContents} in which to launh the {@link
InfoBar}.
On 2014/09/18 00:40:21, Ted C wrote:
> want to take another stab at this spelling :-)

Done. :)

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.cc
(right):

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.cc:66: return
false;
On 2014/09/18 00:40:21, Ted C wrote:
> does something else handle closing this?
> 
> Just wondering why not returning true

Because I mistakenly assumed it was being closed. I verified that this is not
the case. Done.

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/net/spdyp...
File chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h
(right):

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/net/spdyp...
chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h:19: // and
a link, and is used only by an Android field trial.
On 2014/09/18 17:45:46, marq_ wrote:
> Is this still true? If not -- if iOS support is needed -- then please file a
> bug.

This is still true.

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/ui/androi...
File chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h (right):

https://codereview.chromium.org/581833002/diff/20001/chrome/browser/ui/androi...
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h:16:
Launch(JNIEnv* env, jclass, jobject jweb_contents, jstring jlink_url);
On 2014/09/18 00:40:21, Ted C wrote:
> Wrap the params instead of after void.

Done.

[Ted C, 2014-09-18 18:09:00]

lgtm

[bengr, 2014-09-18 18:12:44]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-09-18 18:13:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/581833002/40001

[commit-bot: I haz the power, 2014-09-18 19:10:35]

Committed patchset #2 (id:40001) as b7ae208ab9f3c2dd2cd95b164343baf76f686eed

[commit-bot: I haz the power, 2014-09-18 19:11:37]

Patchset 2 (id:??) landed as
https://crrev.com/35df204ba23a4d5c13b693bac9c4dd583ce36064
Cr-Commit-Position: refs/heads/master@{#295516}