Enqueue mDns requests if send on socket in progress.

net/dns/mdns_client_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/mdns_client_impl.h"
 
+#include <queue>
+
 #include "base/bind.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/stl_util.h"
 #include "base/time/default_clock.h"
 #include "base/time/time.h"
 #include "net/base/dns_util.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_log.h"
 #include "net/base/rand_callback.h"
 #include "net/dns/dns_protocol.h"
@@ skipping 30 matching lines @@
     if (socket)
       sockets->push_back(socket.release());
   }
 }
 
 MDnsConnection::SocketHandler::SocketHandler(
     scoped_ptr<DatagramServerSocket> socket,
     MDnsConnection* connection)
     : socket_(socket.Pass()),
       connection_(connection),
-      response_(dns_protocol::kMaxMulticastSize) {
+      response_(dns_protocol::kMaxMulticastSize),
+      send_in_progress_(false) {
 }
 
 MDnsConnection::SocketHandler::~SocketHandler() {
 }
 
 int MDnsConnection::SocketHandler::Start() {
   IPEndPoint end_point;
   int rv = socket_->GetLocalAddress(&end_point);
   if (rv != OK)
     return rv;
@@ skipping 23 matching lines @@
 }
 
 void MDnsConnection::SocketHandler::OnDatagramReceived(int rv) {
   if (rv >= OK)
     rv = DoLoop(rv);
 
   if (rv != OK)
     connection_->OnError(this, rv);
 }
 
-int MDnsConnection::SocketHandler::Send(IOBuffer* buffer, unsigned size) {
-  return socket_->SendTo(buffer, size, multicast_addr_,
-                         base::Bind(&MDnsConnection::SocketHandler::SendDone,
-                                    base::Unretained(this) ));
+void MDnsConnection::SocketHandler::Send(
+    const scoped_refptr<IOBufferWithSize>& buffer) {
+  if (send_in_progress_) {
+    send_queue_.push(buffer);
+    return;
+  }
+  int rv = socket_->SendTo(buffer.get(),
+                           buffer->size(),
+                           multicast_addr_,
+                           base::Bind(&MDnsConnection::SocketHandler::SendDone,
+                                      base::Unretained(this)));
+  if (rv == ERR_IO_PENDING) {
+    send_in_progress_ = true;
+    return;

[Sergey Ulanov, 2014/09/19 21:11:27]

Maybe remove return and use else below.

[Vitaly Buka (NO REVIEWS), 2014/09/19 21:33:27]

Done.

+  }
+  if (rv < OK)
+    connection_->OnError(this, rv);
 }
 
 void MDnsConnection::SocketHandler::SendDone(int rv) {
-  // TODO(noamsml): Retry logic.
+  DCHECK(send_in_progress_);
+  if (rv == ERR_IO_PENDING)

[Vitaly Buka (NO REVIEWS), 2014/09/19 21:04:46]

Looks like in both implementations ERR_IO_PENDING check is not needed.

+    return;
+  send_in_progress_ = false;
+  if (rv < OK)
+    connection_->OnError(this, rv);

[Sergey Ulanov, 2014/09/19 21:11:27]

Is OnConnectionError() handler allowed to delete MDnsConnection? if it is then
the code below will crash in that case.
Currently the only implementation of MDnsConnection::Delegate I can find ignores
this call
(https://code.google.com/p/chromium/codesearch#chromium/src/net/dns/mdns_clien...),
so it's not a problem right now, but it may become problem in the future. 

[Vitaly Buka (NO REVIEWS), 2014/09/19 21:33:27]

Done.

+  while (!send_in_progress_ && !send_queue_.empty()) {
+    scoped_refptr<IOBufferWithSize> buffer = send_queue_.front();
+    send_queue_.pop();
+    Send(buffer);
+  }
 }
 
 MDnsConnection::MDnsConnection(MDnsConnection::Delegate* delegate) :
       delegate_(delegate) {
 }
 
 MDnsConnection::~MDnsConnection() {
 }
 
 bool MDnsConnection::Init(MDnsSocketFactory* socket_factory) {
@@ skipping 15 matching lines @@
       socket_handlers_.erase(socket_handlers_.begin() + i);
       VLOG(1) << "Start failed, socket=" << i << ", error=" << rv;
     } else {
       ++i;
     }
   }
   VLOG(1) << "Sockets ready:" << socket_handlers_.size();
   return !socket_handlers_.empty();
 }
 
-bool MDnsConnection::Send(IOBuffer* buffer, unsigned size) {
-  bool success = false;
-  for (size_t i = 0; i < socket_handlers_.size(); ++i) {
-    int rv = socket_handlers_[i]->Send(buffer, size);
-    if (rv >= OK || rv == ERR_IO_PENDING) {
-      success = true;
-    } else {
-      VLOG(1) << "Send failed, socket=" << i << ", error=" << rv;
-    }
-  }
-  return success;
+void MDnsConnection::Send(const scoped_refptr<IOBufferWithSize>& buffer) {
+  for (size_t i = 0; i < socket_handlers_.size(); ++i)
+    socket_handlers_[i]->Send(buffer);
 }
 
-void MDnsConnection::OnError(SocketHandler* loop,
-                             int error) {
+void MDnsConnection::OnError(SocketHandler* loop, int rv) {
+  int socket =
+      std::find(socket_handlers_.begin(), socket_handlers_.end(), loop) -
+      socket_handlers_.begin();
+  VLOG(1) << "Socket error. id=" << socket << ", error=" << rv;
   // TODO(noamsml): Specific handling of intermittent errors that can be handled
   // in the connection.
-  delegate_->OnConnectionError(error);
+  delegate_->OnConnectionError(rv);
 }
 
 void MDnsConnection::OnDatagramReceived(
     DnsResponse* response,
     const IPEndPoint& recv_addr,
     int bytes_read) {
   // TODO(noamsml): More sophisticated error handling.
   DCHECK_GT(bytes_read, 0);
   delegate_->HandlePacket(response, bytes_read);
 }
@@ skipping 11 matching lines @@
 }
 
 bool MDnsClientImpl::Core::SendQuery(uint16 rrtype, std::string name) {
   std::string name_dns;
   if (!DNSDomainFromDot(name, &name_dns))
     return false;
 
   DnsQuery query(0, name_dns, rrtype);
   query.set_flags(0);  // Remove the RD flag from the query. It is unneeded.
 
-  return connection_->Send(query.io_buffer(), query.io_buffer()->size());
+  connection_->Send(query.io_buffer());
+  return true;
 }
 
 void MDnsClientImpl::Core::HandlePacket(DnsResponse* response,
                                         int bytes_read) {
   unsigned offset;
   // Note: We store cache keys rather than record pointers to avoid
   // erroneous behavior in case a packet contains multiple exclusive
   // records with the same type and name.
   std::map<MDnsCache::Key, MDnsCache::UpdateType> update_keys;
 
@@ skipping 497 matching lines @@
 
 void MDnsTransactionImpl::OnNsecRecord(const std::string& name, unsigned type) {
   TriggerCallback(RESULT_NSEC, NULL);
 }
 
 void MDnsTransactionImpl::OnCachePurged() {
   // TODO(noamsml): Cache purge situations not yet implemented
 }
 
 }  // namespace net