Define a new media_cast component for iOS cast builds

Define a new media_cast target which provides the minimal functionality
required by media/cast.

The full media target cannot be easily built for some platform (namely
iOS aarch64), typically because of assembly code. The new target has no
such issues.

The change also includes modifications to the media/cast build file to
simplify the dependency list and enable builds using the media_cast
component via a build variable.

BUG=415335
Committed: https://crrev.com/093dbe3588ba58a5bd399ea26cd3274fbace2716
Cr-Commit-Position: refs/heads/master@{#296101}

[jfroy, 2014-09-17 22:12:19]

jfroy@chromium.org changed reviewers:
+ dalecurtis@chromium.org, hclam@google.com, hubbe@chromium.org,
miu@chromium.org, rsesek@chromium.org, scherkus@chromium.org

[DaleCurtis, 2014-09-17 23:04:37]

Please update the BUILD.gn file, otherwise this looks fine to me.

[jfroy, 2014-09-17 23:54:22]

I wanted to get feedback on the idea itself. I'll write the GN version.
Thanks!
On Wed, Sep 17, 2014 at 16:04 <dalecurtis@chromium.org> wrote:

> Please update the BUILD.gn file, otherwise this looks fine to me.
>
> https://codereview.chromium.org/581803003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[miu, 2014-09-17 23:56:00]

lgtm % GN build file changes and the following:

https://codereview.chromium.org/581803003/diff/1/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/581803003/diff/1/media/media.gyp#newcode1490
media/media.gyp:1490: 'target_name': 'media_cast',
The target name sounds like this is building the Cast library.  Perhaps it
should be named something like media_subset_for_cast.

[Alpha Left Google, 2014-09-17 23:59:27]

hclam@chromium.org changed reviewers:
+ hclam@chromium.org

[Alpha Left Google, 2014-09-17 23:59:27]

https://codereview.chromium.org/581803003/diff/1/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/581803003/diff/1/media/media.gyp#newcode1489
media/media.gyp:1489: # GN version: //media:media_cast
I don't think media_cast is the suitable name. This target seems to be only for
cast on ios. So maybe media_for_cast_ios?

[jfroy, 2014-09-19 17:48:41]

Renamed to media_for_cast_ios and added a GN version. I've been trying to check
the gn version, but every time I try to gn gen, I get a failure somewhere. Seems
like gn BUILD files are in flux and generally not working yet...

[jfroy, 2014-09-19 17:49:50]

I've also removed the build variable and instead have the cast components use
media_for_cast_ios automatically when targeting iOS.

[jfroy, 2014-09-19 18:01:57]

Just sent another patch set which excludes software codec sources from iOS
builds, since they need the full media component to be built.

[Alpha Left Google, 2014-09-19 18:58:22]

lgtm

[jfroy, 2014-09-22 18:38:25]

Waiting on media owner to review and sign off.

[DaleCurtis, 2014-09-22 20:02:47]

lgtm

[jfroy, 2014-09-22 20:08:53]

The CQ bit was checked by jfroy@chromium.org

[commit-bot: I haz the power, 2014-09-22 20:10:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/581803003/60001

[commit-bot: I haz the power, 2014-09-22 20:22:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 20:22:15]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[jfroy, 2014-09-22 21:08:50]

On 2014/09/22 20:22:15, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_gn_rel on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   win_chromium_compile_dbg on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

I've fixed the gn issue with patch set 5 (excluded the new component when is_ios
is false). Looking at the mac bot failures (seems that it's trying to build the
new component and running into link errors due to missing CoreVideo symbols and
a YUV conversion function).

[jfroy, 2014-09-22 21:18:20]

I've moved the new component to a conditional block in media.gyp as well. No
changes to source code or target definitions. Sending to the CQ again.

[jfroy, 2014-09-22 21:19:09]

The CQ bit was checked by jfroy@chromium.org

[commit-bot: I haz the power, 2014-09-22 21:20:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/581803003/100001

[commit-bot: I haz the power, 2014-09-22 21:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 21:59:57]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jfroy, 2014-09-22 22:56:29]

The latest patch set restores target dependencies in cast_sender and
cast_receiver that were removed in earlier patch sets but are necessary for
tests. They don't cause any issues for iOS builds. The net patch is now smaller
(fewer lines changed, less impact), so I'm going to send it to the CQ.

[jfroy, 2014-09-22 22:56:49]

The CQ bit was checked by jfroy@chromium.org

[commit-bot: I haz the power, 2014-09-22 22:57:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/581803003/120001

[commit-bot: I haz the power, 2014-09-22 23:56:45]

Committed patchset #7 (id:120001) as b79e319021a400fad888f8cf58a633a0b5b56673

[commit-bot: I haz the power, 2014-09-22 23:57:18]

Patchset 7 (id:??) landed as
https://crrev.com/093dbe3588ba58a5bd399ea26cd3274fbace2716
Cr-Commit-Position: refs/heads/master@{#296101}