chrome/browser/ssl/ssl_error_classification.h - Issue 581803002: Component updater must fallback on using HTTP on Windows XPSP2 and below

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_error_classification.h

Issue 581803002: Component updater must fallback on using HTTP on Windows XPSP2 and below (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ssl/ssl_blocking_page.cc ('K') | « chrome/browser/ssl/ssl_blocking_page.cc ('k') | chrome/browser/ssl/ssl_error_classification.cc » ('j') | chrome/browser/ssl/ssl_error_classification.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_error_classification.h

diff --git a/chrome/browser/ssl/ssl_error_classification.h b/chrome/browser/ssl/ssl_error_classification.h

index f1fc6ef200483114bb5bde4d9f6b5bcac3a94d95..01f86fa421a6c815a5fc2e68de3ce43c4adbdb16 100644

--- a/chrome/browser/ssl/ssl_error_classification.h

+++ b/chrome/browser/ssl/ssl_error_classification.h

@@ -40,7 +40,8 @@ class SSLErrorClassification : public content::NotificationObserver {

// using a version of Chrome which is more than 1 year old.

static bool IsUserClockInTheFuture(const base::Time& time_now);

- static bool IsWindowsVersionSP3OrLower();

+ // Returns true if the OS platform is likely to have SHA-256 support.

+ static bool MaybeOSHasSHA256Support();

// A function which calculates the severity score when the ssl error is

// |CERT_DATE_INVALID|. The calculated score is between 0.0 and 1.0, higher