Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3065)

Unified Diff: chrome/browser/ssl/ssl_error_classification.cc

Issue 581803002: Component updater must fallback on using HTTP on Windows XPSP2 and below (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_error_classification.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_error_classification.cc
diff --git a/chrome/browser/ssl/ssl_error_classification.cc b/chrome/browser/ssl/ssl_error_classification.cc
index 7f66b61f0447a141fba89f9c322af4ea6070cc0e..12983f5b9c608c0dd88ef3fdfec7ae53d5dbc00a 100644
--- a/chrome/browser/ssl/ssl_error_classification.cc
+++ b/chrome/browser/ssl/ssl_error_classification.cc
@@ -30,6 +30,7 @@
#endif
#if defined(OS_WIN)
+#include "base/win/win_util.h"
#include "base/win/windows_version.h"
#endif
@@ -366,14 +367,12 @@ bool SSLErrorClassification::IsUserClockInTheFuture(
return false;
}
-bool SSLErrorClassification::IsWindowsVersionSP3OrLower() {
+bool SSLErrorClassification::MaybeWindowsLacksSHA256Support() {
#if defined(OS_WIN)
- const base::win::OSInfo* os_info = base::win::OSInfo::GetInstance();
- base::win::OSInfo::ServicePack service_pack = os_info->service_pack();
- if (os_info->version() < base::win::VERSION_VISTA && service_pack.major < 3)
- return true;
-#endif
+ return !base::win::MaybeHasSHA256Support();
+#else
return false;
+#endif
}
bool SSLErrorClassification::IsHostNameKnownTLD(const std::string& host_name) {
« no previous file with comments | « chrome/browser/ssl/ssl_error_classification.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698