Component updater must fallback on using HTTP on Windows XPSP2 and below

chrome/browser/ssl/ssl_blocking_page.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/ssl_blocking_page.h"
 
 #include "base/build_time.h"
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/i18n/time_formatting.h"
@@ skipping 452 matching lines @@
     load_time_data.SetString(
         "primaryButtonText",
         l10n_util::GetStringUTF16(IDS_SSL_OVERRIDABLE_SAFETY_BUTTON));
     load_time_data.SetString(
         "finalParagraph",
         l10n_util::GetStringFUTF16(IDS_SSL_OVERRIDABLE_PROCEED_PARAGRAPH,
                                    url));
   } else {
     SSLErrorInfo::ErrorType type =
         SSLErrorInfo::NetErrorToErrorType(cert_error_);
-    if (type == SSLErrorInfo::CERT_INVALID && SSLErrorClassification::
-        IsWindowsVersionSP3OrLower()) {
+    if (type == SSLErrorInfo::CERT_INVALID && !SSLErrorClassification::
+        MaybeOSHasSHA256Support()) {
       load_time_data.SetString(

[felt, 2014/09/18 18:30:36]

This check displays the string IDS_SSL_NONOVERRIDABLE_MORE_INVALID_SP3, which
says:

Your computer is running an old version of Microsoft Windows that cannot process
this website's security certificate. Because of this problem, Chromium can't
tell whether the certificate came from <ph
name="SITE">$1<ex>google.com</ex></ph> or from someone on your network
pretending to be <ph name="SITE">$1<ex>google.com</ex></ph>. Please update your
computer to a more recent version of Windows.

Is that still correct, given the new semantics of MaybeOSHasSHA256Support()?

[Sorin Jianu, 2014/09/18 18:41:07]

The observable behavior of the code should be the same as before. The semantics
of the call are unchanged. Since this it appears this is Windows specific,
should I introduce a platform specific compile time check to only run this code
on OS_WIN?

[felt, 2014/09/18 18:44:27]

No, if the behavior is the same, then that's fine.

[felt, 2014/09/18 18:52:23]

(Please feel free to add the platform specific compile time check if you'd like
though, I don't object to it.)

           "explanationParagraph",
           l10n_util::GetStringFUTF16(
               IDS_SSL_NONOVERRIDABLE_MORE_INVALID_SP3, url));
     } else if (bad_clock) {
       load_time_data.SetString("explanationParagraph",
                                l10n_util::GetStringFUTF16(
                                    IDS_SSL_CLOCK_ERROR_EXPLANATION, url));
     } else {
       load_time_data.SetString("explanationParagraph",
                                l10n_util::GetStringFUTF16(
@@ skipping 167 matching lines @@
   for (; i < 5; i++) {
     strings->SetString(keys[i], std::string());
   }
 }
 
 void SSLBlockingPage::OnGotHistoryCount(bool success,
                                         int num_visits,
                                         base::Time first_visit) {
   num_visits_ = num_visits;
 }