Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: pkg/stack_trace/lib/src/chain.dart

Issue 581693003: Remove some additional Chain.track documentation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/stack_trace/lib/src/stack_zone_specification.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/stack_trace/lib/src/chain.dart
diff --git a/pkg/stack_trace/lib/src/chain.dart b/pkg/stack_trace/lib/src/chain.dart
index e4ac534369ab21b726584b816c22194749ec9ed2..f027025be5ea519066f037a2269fd95c6e617910 100644
--- a/pkg/stack_trace/lib/src/chain.dart
+++ b/pkg/stack_trace/lib/src/chain.dart
@@ -35,14 +35,6 @@ typedef void ChainHandler(error, Chain chain);
/// print("Caught error $error\n"
/// "$stackChain");
/// });
-///
-/// For the most part [Chain.capture] will notice when an error is thrown and
-/// associate the correct stack chain with it; the chain can be accessed using
-/// [new Chain.forTrace]. However, there are some cases where exceptions won't
-/// be automatically detected: any [Future] constructor,
-/// [Completer.completeError], [Stream.addError], and libraries that use these.
-/// For these, all you need to do is wrap the Future or Stream in a call to
-/// [Chain.track] and the errors will be tracked correctly.
class Chain implements StackTrace {
/// The line used in the string representation of stack chains to represent
/// the gap between traces.
@@ -69,13 +61,6 @@ class Chain implements StackTrace {
/// parent Zone's `unhandledErrorHandler` will be called with the error and
/// its chain.
///
- /// For the most part an error thrown in the zone will have the correct stack
- /// chain associated with it. However, there are some cases where exceptions
- /// won't be automatically detected: any [Future] constructor,
- /// [Completer.completeError], [Stream.addError], and libraries that use
- /// these. For these, all you need to do is wrap the Future or Stream in a
- /// call to [Chain.track] and the errors will be tracked correctly.
- ///
/// Note that even if [onError] isn't passed, this zone will still be an error
/// zone. This means that any errors that would cross the zone boundary are
/// considered unhandled.
« no previous file with comments | « no previous file | pkg/stack_trace/lib/src/stack_zone_specification.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698