Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 581643004: Copy edit Learn Basics section. (Closed)

Created:
6 years, 3 months ago by jpmedley
Modified:
6 years, 3 months ago
Reviewers:
mkearney1, smain, JF, binji
CC:
chromium-reviews, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Copy edit Learn Basics section. Includes first group of new illustrations to make overall site images look googly and at the same time part of a single design process. BUG=none R= TEST=none NOTRY=true (documentation only change) Committed: https://crrev.com/3e1df835d674fd12add70332fda9cd349a7423fa Cr-Commit-Position: refs/heads/master@{#296017}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Changes from Patch Set 1 feedback. #

Total comments: 19

Patch Set 3 : Changes from Patch Set 2 feedback. #

Total comments: 8

Patch Set 4 : Changes from Patch Set 3 feedback. #

Total comments: 2

Patch Set 5 : Correct cut and paste error. #

Messages

Total messages: 19 (4 generated)
jpmedley
6 years, 3 months ago (2014-09-17 22:48:42 UTC) #2
jpmedley
6 years, 3 months ago (2014-09-18 14:03:54 UTC) #4
binji
driveby feedback. I like the changes, and the new images look great! https://codereview.chromium.org/581643004/diff/1/native_client_sdk/src/doc/nacl-and-pnacl.rst File native_client_sdk/src/doc/nacl-and-pnacl.rst ...
6 years, 3 months ago (2014-09-18 17:58:38 UTC) #6
native-client-reviews_googlegroups.com
There are more of those to come. I'm going for googly colors and a consistent ...
6 years, 3 months ago (2014-09-18 18:41:42 UTC) #7
chromium-reviews
There are more of those to come. I'm going for googly colors and a consistent ...
6 years, 3 months ago (2014-09-18 18:41:43 UTC) #8
jpmedley
PTAL https://codereview.chromium.org/581643004/diff/1/native_client_sdk/src/doc/nacl-and-pnacl.rst File native_client_sdk/src/doc/nacl-and-pnacl.rst (right): https://codereview.chromium.org/581643004/diff/1/native_client_sdk/src/doc/nacl-and-pnacl.rst#newcode61 native_client_sdk/src/doc/nacl-and-pnacl.rst:61: the pexe , even on new architectures. Moreover, ...
6 years, 3 months ago (2014-09-18 19:03:00 UTC) #9
JF
https://codereview.chromium.org/581643004/diff/20001/native_client_sdk/src/doc/nacl-and-pnacl.rst File native_client_sdk/src/doc/nacl-and-pnacl.rst (right): https://codereview.chromium.org/581643004/diff/20001/native_client_sdk/src/doc/nacl-and-pnacl.rst#newcode29 native_client_sdk/src/doc/nacl-and-pnacl.rst:29: platform. This is neither portable nor conveient, making it ...
6 years, 3 months ago (2014-09-19 18:16:17 UTC) #10
jpmedley
PTAL https://codereview.chromium.org/581643004/diff/20001/native_client_sdk/src/doc/nacl-and-pnacl.rst File native_client_sdk/src/doc/nacl-and-pnacl.rst (right): https://codereview.chromium.org/581643004/diff/20001/native_client_sdk/src/doc/nacl-and-pnacl.rst#newcode29 native_client_sdk/src/doc/nacl-and-pnacl.rst:29: platform. This is neither portable nor conveient, making ...
6 years, 3 months ago (2014-09-19 20:40:33 UTC) #11
JF
https://codereview.chromium.org/581643004/diff/20001/native_client_sdk/src/doc/nacl-and-pnacl.rst File native_client_sdk/src/doc/nacl-and-pnacl.rst (right): https://codereview.chromium.org/581643004/diff/20001/native_client_sdk/src/doc/nacl-and-pnacl.rst#newcode49 native_client_sdk/src/doc/nacl-and-pnacl.rst:49: #. compiling the source code to a bitcode executable ...
6 years, 3 months ago (2014-09-22 16:53:05 UTC) #12
jpmedley
PTAL https://codereview.chromium.org/581643004/diff/40001/native_client_sdk/src/doc/nacl-and-pnacl.rst File native_client_sdk/src/doc/nacl-and-pnacl.rst (right): https://codereview.chromium.org/581643004/diff/40001/native_client_sdk/src/doc/nacl-and-pnacl.rst#newcode25 native_client_sdk/src/doc/nacl-and-pnacl.rst:25: near-native speeds and taking advantage of multiple cores ...
6 years, 3 months ago (2014-09-22 17:19:51 UTC) #13
JF
lgtm after line-swap fix. https://codereview.chromium.org/581643004/diff/60001/native_client_sdk/src/doc/nacl-and-pnacl.rst File native_client_sdk/src/doc/nacl-and-pnacl.rst (right): https://codereview.chromium.org/581643004/diff/60001/native_client_sdk/src/doc/nacl-and-pnacl.rst#newcode40 native_client_sdk/src/doc/nacl-and-pnacl.rst:40: Chrome Web Store. The line ...
6 years, 3 months ago (2014-09-22 17:36:56 UTC) #14
jpmedley
https://codereview.chromium.org/581643004/diff/60001/native_client_sdk/src/doc/nacl-and-pnacl.rst File native_client_sdk/src/doc/nacl-and-pnacl.rst (right): https://codereview.chromium.org/581643004/diff/60001/native_client_sdk/src/doc/nacl-and-pnacl.rst#newcode40 native_client_sdk/src/doc/nacl-and-pnacl.rst:40: Chrome Web Store. On 2014/09/22 17:36:56, JF wrote: > ...
6 years, 3 months ago (2014-09-22 18:26:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581643004/80001
6 years, 3 months ago (2014-09-22 18:26:59 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 54b5ad050eed9b55fefe83b53e419867e617b610
6 years, 3 months ago (2014-09-22 18:27:38 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 18:28:19 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/3e1df835d674fd12add70332fda9cd349a7423fa
Cr-Commit-Position: refs/heads/master@{#296017}

Powered by Google App Engine
This is Rietveld 408576698