Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 581593003: Added 'contextReady' message for HostPairingScreen. (Closed)

Created:
6 years, 3 months ago by dzhioev (left Google)
Modified:
6 years, 3 months ago
Reviewers:
ygorshenin1
CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added 'contextReady' message for HostPairingScreen. Sometimes the screen starts to send updates to JS part to early, when screen is not registered yet. As a result several messages with context diffs could be ignored, and JS context became inconsistent with C++ context. I added 'contextReady' message, that is send from JS when context is ready to recieve updates. Before that the screen handler caches changes in the local context. BUG=375191 Committed: https://crrev.com/b817eec554070b33011842ad9e4fc8185670dfc2 Cr-Commit-Position: refs/heads/master@{#295944}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M chrome/browser/chromeos/login/screens/screen_context.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.js View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc View 1 4 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
dzhioev (left Google)
6 years, 3 months ago (2014-09-17 18:31:47 UTC) #2
ygorshenin1
Could you please also fill a bug for the CL? https://codereview.chromium.org/581593003/diff/1/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h File chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h (right): https://codereview.chromium.org/581593003/diff/1/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h#newcode39 ...
6 years, 3 months ago (2014-09-18 16:51:48 UTC) #3
dzhioev (left Google)
> Could you please also fill a bug for the CL? Attached to the existing ...
6 years, 3 months ago (2014-09-19 15:54:04 UTC) #4
ygorshenin1
lgtm
6 years, 3 months ago (2014-09-22 09:01:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581593003/20001
6 years, 3 months ago (2014-09-22 09:05:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b973ecdc62610c3ad5c4fa20a9bc02dd7a281f37
6 years, 3 months ago (2014-09-22 09:48:52 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 09:49:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b817eec554070b33011842ad9e4fc8185670dfc2
Cr-Commit-Position: refs/heads/master@{#295944}

Powered by Google App Engine
This is Rietveld 408576698