Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 581583004: Importer - Add policy changes for ImportAutofillFormData (Closed)

Created:
6 years, 3 months ago by Nikhil
Modified:
6 years, 3 months ago
CC:
chromium-reviews, joaodasilva+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Importer - Add policy changes for ImportAutofillFormData This patch adds the enterprise policy changes for ImportAutofillFormData preference. BUG=415975 Committed: https://crrev.com/d352c7a30fe31dbb91e45df40b6d1f3299895948 Cr-Commit-Position: refs/heads/master@{#295742}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback (update latest value) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +13 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 chunks +21 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Nikhil
isherman@ - Could you please take a look at this CL? It is a result ...
6 years, 3 months ago (2014-09-18 10:31:53 UTC) #2
Joao da Silva
policy changes lgtm, thanks for doing this! https://codereview.chromium.org/581583004/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/581583004/diff/1/components/policy/resources/policy_templates.json#newcode126 components/policy/resources/policy_templates.json:126: # For ...
6 years, 3 months ago (2014-09-18 12:25:44 UTC) #4
Ilya Sherman
LGTM. Thanks for being diligent about following up on this, Nikhil! :)
6 years, 3 months ago (2014-09-18 18:07:24 UTC) #5
Nikhil
Thanks Joao and Ilya for reviewing this! I've made the suggested change. Also, I've filed ...
6 years, 3 months ago (2014-09-19 15:05:16 UTC) #6
Ilya Sherman
On 2014/09/19 15:05:16, Nikhil wrote: > Thanks Joao and Ilya for reviewing this! I've made ...
6 years, 3 months ago (2014-09-19 17:18:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581583004/20001
6 years, 3 months ago (2014-09-19 17:19:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 18b2e37d02b5d4e196ebb18e6281020626866aa3
6 years, 3 months ago (2014-09-19 18:25:43 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 18:26:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d352c7a30fe31dbb91e45df40b6d1f3299895948
Cr-Commit-Position: refs/heads/master@{#295742}

Powered by Google App Engine
This is Rietveld 408576698