Remove flag --disable-genius-app since it's been public launched for several milestones

Remove flag --disable-genius-app since it's been public launched for several milestones

BUG=chromium:350245
Committed: https://crrev.com/15e2397e16d44d12199bea0069fd8b5d16d354fb
Cr-Commit-Position: refs/heads/master@{#295517}

[cylee1, 2014-09-17 11:43:37]

cylee@chromium.org changed reviewers:
+ dpolukhin@chromium.org

[cylee1, 2014-09-17 18:10:41]

cylee@chromium.org changed reviewers:
+ sky@chromium.org, yoz@chromium.org

[sky, 2014-09-17 19:43:26]

https://codereview.chromium.org/581583003/diff/1/chrome/browser/ui/chrome_pag...
File chrome/browser/ui/chrome_pages.cc (right):

https://codereview.chromium.org/581583003/diff/1/chrome/browser/ui/chrome_pag...
chrome/browser/ui/chrome_pages.cc:83: return;
Nuke the return and make 84 a #else.

https://codereview.chromium.org/581583003/diff/1/chrome/browser/ui/toolbar/wr...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

https://codereview.chromium.org/581583003/diff/1/chrome/browser/ui/toolbar/wr...
chrome/browser/ui/toolbar/wrench_menu_model.cc:204: help_string_id =
IDS_GET_HELP;
Use a #else here too.

[cylee1, 2014-09-18 11:10:30]

https://codereview.chromium.org/581583003/diff/1/chrome/browser/ui/chrome_pag...
File chrome/browser/ui/chrome_pages.cc (right):

https://codereview.chromium.org/581583003/diff/1/chrome/browser/ui/chrome_pag...
chrome/browser/ui/chrome_pages.cc:83: return;
On 2014/09/17 19:43:25, sky wrote:
> Nuke the return and make 84 a #else.

Done.

https://codereview.chromium.org/581583003/diff/1/chrome/browser/ui/toolbar/wr...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

https://codereview.chromium.org/581583003/diff/1/chrome/browser/ui/toolbar/wr...
chrome/browser/ui/toolbar/wrench_menu_model.cc:204: help_string_id =
IDS_GET_HELP;
On 2014/09/17 19:43:25, sky wrote:
> Use a #else here too.

Done.

[cylee1, 2014-09-18 11:14:18]

cylee@chromium.org changed reviewers:
+ scheib@chromium.org

[cylee1, 2014-09-18 11:14:18]

Hi Vincent,
  Need some owner for chrome/browser/extensions, PTAL

[sky, 2014-09-18 13:03:24]

https://codereview.chromium.org/581583003/diff/20001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

https://codereview.chromium.org/581583003/diff/20001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/wrench_menu_model.cc:205: #else
This isn't the same as the old code. I was saying do:
#if defined(OS_CHROMEOS) && defined(OFFICIAL_BUILD)
int help_string_id = IDS_GET_HELP;
#else
int help_tring_id = IDS_HELP_PAGE;
#endif

Or move thee ifdefs into a function that you call from here, so that this code
becomes:

AddItemWithStringId(..., GetHelpStringId());

[cylee1, 2014-09-18 13:25:59]

https://codereview.chromium.org/581583003/diff/20001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

https://codereview.chromium.org/581583003/diff/20001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/wrench_menu_model.cc:205: #else
On 2014/09/18 13:03:24, sky wrote:
> This isn't the same as the old code. I was saying do:
> #if defined(OS_CHROMEOS) && defined(OFFICIAL_BUILD)
> int help_string_id = IDS_GET_HELP;
> #else
> int help_tring_id = IDS_HELP_PAGE;
> #endif
> 
> Or move thee ifdefs into a function that you call from here, so that this code
> becomes:
> 
> AddItemWithStringId(..., GetHelpStringId());

sorry, mistake...

[scheib, 2014-09-18 15:05:05]

lgtm

[sky, 2014-09-18 15:51:05]

LGTM

[cylee1, 2014-09-18 16:23:39]

The CQ bit was checked by cylee@chromium.org

[commit-bot: I haz the power, 2014-09-18 16:24:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/581583003/40001

[commit-bot: I haz the power, 2014-09-18 19:12:50]

Committed patchset #3 (id:40001) as 3d9773a47493fec7be48e0156371768a7d3c3901

[commit-bot: I haz the power, 2014-09-18 19:13:26]

Patchset 3 (id:??) landed as
https://crrev.com/15e2397e16d44d12199bea0069fd8b5d16d354fb
Cr-Commit-Position: refs/heads/master@{#295517}