Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issue 581563002: Declaring the weak_ptr_factory in proper order in src/cc. (Closed)

Created:
6 years, 3 months ago by ARUNKK
Modified:
6 years, 3 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declaring the weak_ptr_factory in proper order in src/cc. Cleaning up weak_ptr_factory destruction order. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Committed: https://crrev.com/03fd39760cfd31da392e596be40fd06c9eff6bf6 Cr-Commit-Position: refs/heads/master@{#295279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M cc/output/output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/output_surface.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/resources/gpu_raster_worker_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ARUNKK
PTAL.
6 years, 3 months ago (2014-09-17 07:10:18 UTC) #2
reveman
lgtm
6 years, 3 months ago (2014-09-17 14:32:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/581563002/1
6 years, 3 months ago (2014-09-17 14:33:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9120faec7e493892345b4bad9f3105439f01ce63
6 years, 3 months ago (2014-09-17 15:42:39 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 15:43:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03fd39760cfd31da392e596be40fd06c9eff6bf6
Cr-Commit-Position: refs/heads/master@{#295279}

Powered by Google App Engine
This is Rietveld 408576698