Skip imported/web-platform-tests/custom-elements/.../no-registry-test.html

Skip imported/web-platform-tests/custom-elements/.../no-registry-test.html

As this test requires http server to run, skip this test in imported/
directory and have the same test in http/.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182558

[deepak.sa, 2014-09-17 11:36:52]

deepak.sa@samsung.com changed reviewers:
+ dominicc@chromium.org, esprehn@chromium.org

[deepak.sa, 2014-09-17 11:36:53]

PTAL?
Thanks!

[dominicc (has gone to gerrit), 2014-09-17 12:25:15]

dominicc@chromium.org changed reviewers:
+ dpranke@google.com

[dominicc (has gone to gerrit), 2014-09-17 12:25:41]

dpranke, is this the preferred way to handle this?

[Dirk Pranke, 2014-09-17 15:13:42]

On 2014/09/17 12:25:41, dominicc wrote:
> dpranke, is this the preferred way to handle this?

Close, but probably not quite. Modifying the actual content of
LayoutTests/imported/web-platform-tests any way other than through
'update-w3c-deps' is problematic, because it means that we can't reproduce the
import state cleanly.

It would be better to change the TestExpectations entry to 'Skip' and leave it
in until we can do another import.

Or, just do another import now; since you've change W3CImportExpectations, the
file will be deleted. The main difference is that the change description will
include the version information from the upstream repos (so we know what was
imported when).

Of course, all of this is just my working theory for how to do imports; I'm open
to other approaches.

[deepak.sa, 2014-09-19 10:23:37]

On 2014/09/17 15:13:42, Dirk Pranke wrote:
> On 2014/09/17 12:25:41, dominicc wrote:
> > dpranke, is this the preferred way to handle this?
> 
> Close, but probably not quite. Modifying the actual content of
> LayoutTests/imported/web-platform-tests any way other than through
> 'update-w3c-deps' is problematic, because it means that we can't reproduce the
> import state cleanly.
> 
> It would be better to change the TestExpectations entry to 'Skip' and leave it
> in until we can do another import.
> 
> Or, just do another import now; since you've change W3CImportExpectations, the
> file will be deleted. The main difference is that the change description will
> include the version information from the upstream repos (so we know what was
> imported when).
> 
> Of course, all of this is just my working theory for how to do imports; I'm
open
> to other approaches.

I would add 'Skip' in both TestExpectations and W3CImportExpectations, so that
it will not fail while running layout tests. Also, it would delete that file in
the next import. 
Also, I would keep the similar test in http/tests/custom-elements/, so that the
test should run properly. 
That sounds right?

[Dirk Pranke, 2014-09-19 18:28:13]

On 2014/09/19 10:23:37, deepak.sa wrote:
> I would add 'Skip' in both TestExpectations and W3CImportExpectations, so that
> it will not fail while running layout tests. Also, it would delete that file
in
> the next import. 
> Also, I would keep the similar test in http/tests/custom-elements/, so that
the
> test should run properly. 
> That sounds right?

Yes.

[deepak.sa, 2014-09-22 11:11:03]

On 2014/09/19 18:28:13, Dirk Pranke wrote:
> On 2014/09/19 10:23:37, deepak.sa wrote:
> > I would add 'Skip' in both TestExpectations and W3CImportExpectations, so
that
> > it will not fail while running layout tests. Also, it would delete that file
> in
> > the next import. 
> > Also, I would keep the similar test in http/tests/custom-elements/, so that
> the
> > test should run properly. 
> > That sounds right?
> 
> Yes.

I have uploaded a new patchset.
PTAL?
Thanks!

[deepak.sa, 2014-09-23 13:05:05]

Ping!

[Dirk Pranke, 2014-09-23 20:08:24]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2014-09-23 20:08:25]

lgtm, thanks!

[deepak.sa, 2014-09-24 05:19:38]

The CQ bit was checked by deepak.sa@samsung.com

[commit-bot: I haz the power, 2014-09-24 05:20:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/581543002/40001

[commit-bot: I haz the power, 2014-09-24 06:02:00]

Committed patchset #3 (id:40001) as 182558