Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: bindings/scripts/utilities.py

Issue 581453002: Dartium Roll 38 roll (Closed) Base URL: https://dart.googlecode.com/svn/third_party/WebCore
Patch Set: Sync'd w/ r 182210 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bindings/scripts/interface_dependency_resolver.py ('k') | bindings/scripts/v8_attributes.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bindings/scripts/utilities.py
diff --git a/bindings/scripts/utilities.py b/bindings/scripts/utilities.py
index 0aeabc20b3610e6fbef41af25430e1b57cd958e5..367476598a1b8e0b115f749d41ce258941e91d78 100644
--- a/bindings/scripts/utilities.py
+++ b/bindings/scripts/utilities.py
@@ -119,6 +119,11 @@ def is_callback_interface_from_idl(file_contents):
return bool(match)
+def is_dictionary_from_idl(file_contents):
+ match = re.search(r'dictionary\s+\w+\s*{', file_contents)
+ return bool(match)
+
+
def get_parent_interface(file_contents):
match = re.search(r'interface\s+'
r'\w+\s*'
@@ -148,10 +153,10 @@ def get_interface_extended_attributes_from_idl(file_contents):
extended_attributes_string = match.group(1)
extended_attributes = {}
- # FIXME: this splitting is WRONG: it fails on ExtendedAttributeArgList like
- # 'NamedConstructor=Foo(a, b)'
+ # FIXME: this splitting is WRONG: it fails on extended attributes where lists of
+ # multiple values are used, which are seperated by a comma and a space.
parts = [extended_attribute.strip()
- for extended_attribute in extended_attributes_string.split(',')
+ for extended_attribute in re.split(',\s+', extended_attributes_string)
# Discard empty parts, which may exist due to trailing comma
if extended_attribute.strip()]
for part in parts:
« no previous file with comments | « bindings/scripts/interface_dependency_resolver.py ('k') | bindings/scripts/v8_attributes.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698