bindings/scripts/generate_global_constructors.py - Issue 581453002: Dartium Roll 38 roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bindings/scripts/generate_global_constructors.py

Issue 581453002: Dartium Roll 38 roll (Closed) Base URL: https://dart.googlecode.com/svn/third_party/WebCore

Patch Set: Sync'd w/ r 182210 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bindings/scripts/generate_global_constructors.py

diff --git a/bindings/scripts/generate_global_constructors.py b/bindings/scripts/generate_global_constructors.py

index 81838fe1865d5f819eaa9e7bdd41e2bd458584bc..1be2ac3327c730f529759f552f658bfeff42f7c5 100755

--- a/bindings/scripts/generate_global_constructors.py

+++ b/bindings/scripts/generate_global_constructors.py

@@ -86,9 +86,7 @@ def record_global_constructors(idl_filename):

# member the extended attribute applies to will be exposed only on objects

# associated with ECMAScript global environments whose global object

# implements an interface that has a matching global name.

- # FIXME: In spec names are comma-separated, but that makes parsing very

- # difficult (https://www.w3.org/Bugs/Public/show_bug.cgi?id=24959).

- exposed_global_names = extended_attributes.get('Exposed', 'Window').split('&')

+ exposed_global_names = extended_attributes.get('Exposed', 'Window').strip('()').split(',')

new_constructors_list = generate_global_constructors_list(interface_name, extended_attributes)

for exposed_global_name in exposed_global_names:

global_name_to_constructors[exposed_global_name].extend(new_constructors_list)