Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 581433002: Change visibility of methods only called by JNI counter-part of the class. (Closed)

Created:
6 years, 3 months ago by aurimas (slooooooooow)
Modified:
6 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, klundberg+watch_chromium.org, android-webview-reviews_chromium.org, yfriedman+watch_chromium.org, mkosiba (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change visibility of methods only called by JNI counter-part of the class. BUG=414820 Committed: https://crrev.com/b09e82f8eaf5c5cb582c80d94aa9e23ef275c800 Cr-Commit-Position: refs/heads/master@{#295193}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Move annotations around #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwWebResourceResponse.java View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
PTAL
6 years, 3 months ago (2014-09-16 21:22:10 UTC) #2
boliu
cc mkosiba lgtm
6 years, 3 months ago (2014-09-16 21:30:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/581433002/40001
6 years, 3 months ago (2014-09-16 22:17:32 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 29b671f2781af1da07414e1c36508ca2f9655d65
6 years, 3 months ago (2014-09-17 00:48:42 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 00:49:29 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b09e82f8eaf5c5cb582c80d94aa9e23ef275c800
Cr-Commit-Position: refs/heads/master@{#295193}

Powered by Google App Engine
This is Rietveld 408576698