Source/core/page/Page.cpp - Issue 58143002: WindowBase64::atob() does not remove space characters from input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Page.cpp

Issue 58143002: WindowBase64::atob() does not remove space characters from input (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix style issue Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/Page.cpp

diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp

index 57dfbb041bf860fb13e8ee64cede7f63d0aa5c84..73617a804eab96456668d467fc9f4d2f5590c10e 100644

--- a/Source/core/page/Page.cpp

+++ b/Source/core/page/Page.cpp

@@ -405,7 +405,7 @@ void Page::userStyleSheetLocationChanged()

m_didLoadUserStyleSheet = true;

Vector<char> styleSheetAsUTF8;

- if (base64Decode(decodeURLEscapeSequences(url.string().substring(35)), styleSheetAsUTF8, Base64IgnoreWhitespace))

+ if (base64Decode(decodeURLEscapeSequences(url.string().substring(35)), styleSheetAsUTF8, isSpaceOrNewline))

m_userStyleSheet = String::fromUTF8(styleSheetAsUTF8.data(), styleSheetAsUTF8.size());

}

« LayoutTests/fast/dom/Window/atob-btoa.html ('K') | « Source/core/frame/DOMWindowBase64.cpp ('k') | Source/wtf/text/Base64.h » ('j') | Source/wtf/text/Base64.h » ('J')