android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java - Issue 581423002: [aw] Ensure that WebView APIs do not crash if called after destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

Issue 581423002: [aw] Ensure that WebView APIs do not crash if called after destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix findbugs warning. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

index 91c583f69938f1dbad96ce964ae548d755bbbe82..6c2842f19635061e1e2b11ce30b5e245f0287a01 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

@@ -60,7 +60,10 @@ public class AwContentViewClient extends ContentViewClient {

if (mAwContents.isFullScreen()) {

return;

}

- viewGroup.addView(mAwContents.enterFullScreen());

+ View fullscreenView = mAwContents.enterFullScreen();

+ if (fullscreenView != null) {

+ viewGroup.addView(fullscreenView);

+ }

}

});

mAwContentsClient.onShowCustomView(viewGroup, cb);

« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »