Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 581413002: Invoke V8::Initialize() explicitly during V8 setup (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium/@master
Visibility:
Public.

Description

Invoke V8::Initialize() explicitly during V8 setup BUG=none R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0c53324519762525e17ebbacc02cd33f7f1c837d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-19 11:38:24 UTC) #1
jam
lgtm
6 years, 3 months ago (2014-09-19 18:44:41 UTC) #2
jam
lgtm lgtm
6 years, 3 months ago (2014-09-19 18:44:42 UTC) #3
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-22 06:46:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 0c53324 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698