Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 581383002: Create GN build step for transform_additional_modules_list.py. (Closed)

Created:
6 years, 3 months ago by engedy
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Create GN build step for transform_additional_modules_list.py. BUG=None Committed: https://crrev.com/99d0e11b55c3bb86717bb5a727e9500144f166e2 Cr-Commit-Position: refs/heads/master@{#297416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
engedy
Brett, Erik, please take a look.
6 years, 3 months ago (2014-09-19 09:38:10 UTC) #2
erikwright (departed)
LGTM
6 years, 3 months ago (2014-09-23 15:12:56 UTC) #3
engedy
Brett, friendly ping.
6 years, 2 months ago (2014-09-25 12:36:01 UTC) #4
brettw
LGTM, sorry I missed this.
6 years, 2 months ago (2014-09-25 20:35:38 UTC) #5
engedy
@Jochen, please take a look for Owner's approval.
6 years, 2 months ago (2014-09-29 09:08:59 UTC) #7
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-09-30 08:16:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581383002/1
6 years, 2 months ago (2014-09-30 12:56:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5147fab302c91568d8e7c1dc581a2126c17cb540
6 years, 2 months ago (2014-09-30 13:32:48 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 13:33:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99d0e11b55c3bb86717bb5a727e9500144f166e2
Cr-Commit-Position: refs/heads/master@{#297416}

Powered by Google App Engine
This is Rietveld 408576698