Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 581303002: Restrict the File System Provier API permission to Chrome OS only. (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 3 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Restrict the File System Provier API permission to Chrome OS only. This API implementation is compiled on Chrome OS only, so the permission should be available on Chrome OS only. TEST=Tested manually that still works on Chrome OS. BUG=248427 Committed: https://crrev.com/bbe7526503cbf1fc019d4e2c5eea8bf661588f52 Cr-Commit-Position: refs/heads/master@{#295918}

Patch Set 1 #

Patch Set 2 : Added a notice. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/fileSystemProvider.html View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
mtomasz
@miket: PTAL. Thanks!
6 years, 3 months ago (2014-09-19 02:11:34 UTC) #2
miket_OOO
On 2014/09/19 02:11:34, mtomasz wrote: > @miket: PTAL. Thanks! Do the docs reflect this limited ...
6 years, 3 months ago (2014-09-19 19:04:39 UTC) #3
mtomasz
On 2014/09/19 19:04:39, miket wrote: > On 2014/09/19 02:11:34, mtomasz wrote: > > @miket: PTAL. ...
6 years, 3 months ago (2014-09-20 00:35:58 UTC) #4
mtomasz
On 2014/09/20 00:35:58, mtomasz wrote: > On 2014/09/19 19:04:39, miket wrote: > > On 2014/09/19 ...
6 years, 3 months ago (2014-09-22 01:16:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581303002/20001
6 years, 3 months ago (2014-09-22 01:17:02 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-22 03:17:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581303002/20001
6 years, 3 months ago (2014-09-22 03:19:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3c8bd874795b993fec3dbf99bbf05a7c7bae1fcc
6 years, 3 months ago (2014-09-22 03:50:12 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 03:50:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bbe7526503cbf1fc019d4e2c5eea8bf661588f52
Cr-Commit-Position: refs/heads/master@{#295918}

Powered by Google App Engine
This is Rietveld 408576698