Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 581273004: Add template for bundling resources generated by previous grit step (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-java-proto
Project:
chromium
Visibility:
Public.

Description

Add template for bundling resources generated by previous grit step //chrome/app:generated_resources generates a bunch of android resources. In Gyp, we just add these to chrome_java by including all resources in that particular output directory. We don't support that pattern in GN (because it's bad). So, this adds a template that handles bundling resources generated that way as a normal android_resources target. Adds such a target from //chrome/app:generated_resources BUG=359249 Committed: https://crrev.com/56e7b7c3948ff4c9acb992cc5b1ea5ecb2c591ce Cr-Commit-Position: refs/heads/master@{#298965}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -0 lines) Patch
M build/config/android/rules.gni View 1 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/app/BUILD.gn View 1 2 2 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
cjhopman
newt: *
6 years, 3 months ago (2014-09-19 21:01:00 UTC) #3
newt (away)
lgtm after comment https://codereview.chromium.org/581273004/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/581273004/diff/1/build/config/android/rules.gni#newcode482 build/config/android/rules.gni:482: # java_strings_grd("foo_strings_grd") { update example
6 years, 3 months ago (2014-09-23 05:42:51 UTC) #4
cjhopman
cpu for chrome/app OWNERS
6 years, 2 months ago (2014-10-08 22:37:23 UTC) #6
cjhopman
https://codereview.chromium.org/581273004/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/581273004/diff/1/build/config/android/rules.gni#newcode482 build/config/android/rules.gni:482: # java_strings_grd("foo_strings_grd") { On 2014/09/23 05:42:51, newt wrote: > ...
6 years, 2 months ago (2014-10-08 22:37:56 UTC) #7
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/581273004/diff/40001/chrome/app/BUILD.gn File chrome/app/BUILD.gn (right): https://codereview.chromium.org/581273004/diff/40001/chrome/app/BUILD.gn#newcode9 chrome/app/BUILD.gn:9: please use "else {"
6 years, 2 months ago (2014-10-08 23:32:31 UTC) #8
cjhopman
https://codereview.chromium.org/581273004/diff/40001/chrome/app/BUILD.gn File chrome/app/BUILD.gn (right): https://codereview.chromium.org/581273004/diff/40001/chrome/app/BUILD.gn#newcode9 chrome/app/BUILD.gn:9: On 2014/10/08 23:32:30, cpu wrote: > please use "else ...
6 years, 2 months ago (2014-10-08 23:38:13 UTC) #9
cpu_(ooo_6.6-7.5)
lgtm
6 years, 2 months ago (2014-10-09 19:37:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581273004/60001
6 years, 2 months ago (2014-10-09 20:23:48 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years, 2 months ago (2014-10-09 20:28:37 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 20:29:18 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/56e7b7c3948ff4c9acb992cc5b1ea5ecb2c591ce
Cr-Commit-Position: refs/heads/master@{#298965}

Powered by Google App Engine
This is Rietveld 408576698