Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: mojo/application_manager/BUILD.gn

Issue 581273003: Make mojo/services pass in "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ui
Patch Set: no brackets Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/application/BUILD.gn ('k') | mojo/apps/js/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/application_manager/BUILD.gn
diff --git a/mojo/application_manager/BUILD.gn b/mojo/application_manager/BUILD.gn
index f256c01def35c1947120d88ce2ac7c1601bfab7b..92d4cf198b6f3d96dadbeb3dae0ea926c015941f 100644
--- a/mojo/application_manager/BUILD.gn
+++ b/mojo/application_manager/BUILD.gn
@@ -21,26 +21,31 @@ component("application_manager") {
"MOJO_APPLICATION_MANAGER_IMPLEMENTATION",
]
- deps = [
+ public_deps = [
"//base",
+ "//mojo/common",
+ "//mojo/public/cpp/application",
+ "//mojo/public/interfaces/application:application",
+ "//mojo/services/public/interfaces/network:network",
+ "//url",
+ ]
+ deps = [
"//base/third_party/dynamic_annotations",
"//net",
"//url",
- "//mojo/common",
"//mojo/environment:chromium",
- "//mojo/public/interfaces/application:application",
"//mojo/services/public/interfaces/content_handler:content_handler",
- "//mojo/services/public/interfaces/network:network",
"//mojo/system",
]
-
- forward_dependent_configs_from = [
- "//mojo/public/interfaces/application:application",
- ]
}
# GYP version: mojo.gyp:mojo_application_manager_unittests
test("mojo_application_manager_unittests") {
+ sources = [
+ "application_manager_unittest.cc",
+ "background_shell_application_loader_unittest.cc",
+ ]
+
deps = [
":application_manager",
":test_bindings",
@@ -53,11 +58,6 @@ test("mojo_application_manager_unittests") {
"//testing/gtest",
"//url",
]
-
- sources = [
- "application_manager_unittest.cc",
- "background_shell_application_loader_unittest.cc",
- ]
}
mojom("test_bindings") {
« no previous file with comments | « mojo/application/BUILD.gn ('k') | mojo/apps/js/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698