Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 581273003: Make mojo/services pass in "gn check" (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ui
Project:
chromium
Visibility:
Public.

Description

Make mojo/services pass in "gn check" This mostly just adds the missing dependency identified by the checker. In some cases I looked at the target and added public_deps that I thought were appropriate given the nature of the target. This renames the generated mojo action names to be foo__generator instead of foo_generator since it is not clear from the current name that it is an internally-generated target and I kept trying to use it. The double-underscore matches the Android generated targets. In a few cases I changed ordering (sources come before deps in GN style) but I didn't want to make the changes difficult to diff so didn't do it for most cases. R=darin@chromium.org Committed: https://crrev.com/e2311613971cf63c66b60ebea38b4592b8520b8f Cr-Commit-Position: refs/heads/master@{#295797}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : no brackets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -82 lines) Patch
M gpu/BUILD.gn View 2 chunks +4 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/application_manager/BUILD.gn View 2 chunks +13 lines, -13 lines 0 comments Download
M mojo/apps/js/BUILD.gn View 2 chunks +11 lines, -5 lines 0 comments Download
M mojo/apps/js/bindings/gl/BUILD.gn View 1 chunk +8 lines, -8 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/services/clipboard/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/gles2/BUILD.gn View 2 chunks +9 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/input_events/BUILD.gn View 2 chunks +11 lines, -13 lines 0 comments Download
M mojo/services/public/cpp/surfaces/BUILD.gn View 1 chunk +17 lines, -19 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 2 chunks +11 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/surfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/test_service/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/test_service/test_service_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 4 chunks +8 lines, -1 line 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
brettw
6 years, 3 months ago (2014-09-18 23:57:58 UTC) #2
darin (slow to review)
LGTM (though I am far from a GN expert)
6 years, 3 months ago (2014-09-19 05:49:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581273003/1
6 years, 3 months ago (2014-09-19 16:48:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/17231)
6 years, 3 months ago (2014-09-19 17:02:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581273003/20001
6 years, 3 months ago (2014-09-19 21:30:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581273003/20001
6 years, 3 months ago (2014-09-19 21:30:47 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e2311613971cf63c66b60ebea38b4592b8520b8f Cr-Commit-Position: refs/heads/master@{#295797}
6 years, 3 months ago (2014-09-19 22:56:59 UTC) #12
brettw
Committed patchset #3 (id:40001) manually as e231161 (presubmit successful).
6 years, 3 months ago (2014-09-19 22:57:00 UTC) #13
brettw
6 years, 3 months ago (2014-09-19 23:15:34 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/583423002/ by brettw@chromium.org.

The reason for reverting is: Broke component build.

Powered by Google App Engine
This is Rietveld 408576698