Shadows: crop corner tiles instead of hiding.

ui/wm/core/shadow.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/wm/core/shadow.h"
 
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/compositor/layer.h"
 #include "ui/compositor/scoped_layer_animation_settings.h"
@@ skipping 154 matching lines @@
       image = res.GetImageNamed(IDR_AURA_SHADOW_INACTIVE);
       break;
     case STYLE_SMALL:
       image = res.GetImageNamed(IDR_WINDOW_BUBBLE_SHADOW_SMALL);
       break;
     default:
       NOTREACHED() << "Unhandled style " << style_;
       break;
   }
 
-  // Calculate shadow aperture for style.
-  int shadow_aperture = GetShadowApertureForStyle(style_);
-  gfx::Rect aperture(shadow_aperture,
-                     shadow_aperture,
-                     image.Width() - shadow_aperture * 2,
-                     image.Height() - shadow_aperture * 2);
+  // Update nine-patch layer with new bitmap.

[danakj, 2014/09/18 21:35:29]

Thanks, this comment now just says the function name in a longer way so can
remove?

[hshi1, 2014/09/18 21:37:12]

Done.

+  shadow_layer_->UpdateNinePatchLayerBitmap(image.AsBitmap());
 
-  // Update nine-patch layer with new bitmap and aperture.
-  shadow_layer_->UpdateNinePatchLayerBitmap(image.AsBitmap(), aperture);
+  // Update shadow image size.

[danakj, 2014/09/18 21:35:29]

Similar comment about this comment, wdyt?

[hshi1, 2014/09/18 21:37:12]

Done.

+  image_size_ = image.Size();
 
   // Update interior inset for style.

[hshi1, 2014/09/18 21:37:12]

Lemme remove this line too (the function name is already self-documenting).

   interior_inset_ = GetInteriorInsetForStyle(style_);
 
   // Image sizes may have changed.
   UpdateLayerBounds();
 }
 
 void Shadow::UpdateLayerBounds() {
   // Update bounds based on content bounds and interior inset.
   gfx::Rect layer_bounds = content_bounds_;
   layer_bounds.Inset(-interior_inset_, -interior_inset_);
   layer()->SetBounds(layer_bounds);
   shadow_layer_->SetBounds(gfx::Rect(layer_bounds.size()));
 
-  // Calculate shadow border for style. Note that border is in layer space
-  // and it cannot exceed the bounds of the layer.
-  int shadow_aperture = GetShadowApertureForStyle(style_);
-  gfx::Rect border(shadow_aperture, shadow_aperture,
-                   shadow_aperture * 2, shadow_aperture * 2);
-  if (layer_bounds.width() < border.width() ||
-      layer_bounds.height() < border.height()) {
-    shadow_layer_->SetVisible(false);
-  } else {
-    shadow_layer_->SetVisible(true);
-    shadow_layer_->UpdateNinePatchLayerBorder(border);
-  }
+  // Update the shadow aperture and border for style. Note that border is in
+  // layer space and it cannot exceed the bounds of the layer.
+  int aperture = GetShadowApertureForStyle(style_);
+  int aperture_x = std::min(aperture, layer_bounds.width() / 2);
+  int aperture_y = std::min(aperture, layer_bounds.height() / 2);
+  shadow_layer_->UpdateNinePatchLayerAperture(
+      gfx::Rect(aperture_x, aperture_y,
+                image_size_.width() - aperture_x * 2,
+                image_size_.height() - aperture_y * 2));
+  shadow_layer_->UpdateNinePatchLayerBorder(
+      gfx::Rect(aperture_x, aperture_y, aperture_x * 2, aperture_y * 2));
 }
 
 }  // namespace wm