check for failed file->data

check for failed file->data (fails on mac)

TBR=

Committed: https://skia.googlesource.com/skia/+/48925e3b3179a19b5cebed8ead237633107f160f

[reed1, 2014-09-18 20:30:18]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-09-18 20:30:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/581263002/1

[commit-bot: I haz the power, 2014-09-18 20:57:08]

Committed patchset #1 (id:1) as 48925e3b3179a19b5cebed8ead237633107f160f

[tfarina, 2014-09-19 16:14:48]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2014-09-19 16:14:49]

lgtm

It would be interesting to check-in skia.google.jpeg into
https://skia.googlesource.com/skia/+/master/resources/ directoy to fix this
TODO.

Regards,

https://codereview.chromium.org/581263002/diff/1/gm/image.cpp
File gm/image.cpp (right):

https://codereview.chromium.org/581263002/diff/1/gm/image.cpp#newcode23
gm/image.cpp:23: SkAutoDataUnref
data(SkData::NewFromFileName("/Users/mike/Downloads/skia.google.jpeg"));
The code of NewFromFileName
(https://skia.googlesource.com/skia/+/master/src/core/SkData.cpp#144) is not
identical to fileToData(), but I assume is more robust.

https://codereview.chromium.org/581263002/diff/1/gm/image.cpp#newcode24
gm/image.cpp:24: if (NULL == data.get()) {
OK