Support large objects in the serializer/deserializer.

Support large objects in the serializer/deserializer.

R=hpayer@chromium.org, mvstanton@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24204

[mvstanton, 2014-09-22 14:32:14]

LGTM, one nit.

https://codereview.chromium.org/581223004/diff/1/src/serialize.h
File src/serialize.h (right):

https://codereview.chromium.org/581223004/diff/1/src/serialize.h#newcode529
src/serialize.h:529: int seen_large_objects_index_;
A comment on the meaning of seen_large_objects_index_ would be great.

[Yang, 2014-09-22 15:22:12]

On 2014/09/22 14:32:14, mvstanton wrote:
> LGTM, one nit.
> 
> https://codereview.chromium.org/581223004/diff/1/src/serialize.h
> File src/serialize.h (right):
> 
> https://codereview.chromium.org/581223004/diff/1/src/serialize.h#newcode529
> src/serialize.h:529: int seen_large_objects_index_;
> A comment on the meaning of seen_large_objects_index_ would be great.

uploaded new patchset with comment.

[Hannes Payer (out of office), 2014-09-22 18:21:52]

https://codereview.chromium.org/581223004/diff/20001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/581223004/diff/20001/src/heap/heap.h#newcode1666
src/heap/heap.h:1666: Executability executable);
I don't like that method? Why can't you use AllocateRaw here?

https://codereview.chromium.org/581223004/diff/20001/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/581223004/diff/20001/src/heap/spaces.cc#newco...
src/heap/spaces.cc:2888: void LargeObjectSpace::PrepareForDeserialization(int
large_objects_total_size) {
This method should not be part of large object space. Please move it to heap.

[Yang, 2014-09-23 09:21:34]

On 2014/09/22 18:21:52, Hannes Payer wrote:
> https://codereview.chromium.org/581223004/diff/20001/src/heap/heap.h
> File src/heap/heap.h (right):
> 
>
https://codereview.chromium.org/581223004/diff/20001/src/heap/heap.h#newcode1666
> src/heap/heap.h:1666: Executability executable);
> I don't like that method? Why can't you use AllocateRaw here?
> 
> https://codereview.chromium.org/581223004/diff/20001/src/heap/spaces.cc
> File src/heap/spaces.cc (right):
> 
>
https://codereview.chromium.org/581223004/diff/20001/src/heap/spaces.cc#newco...
> src/heap/spaces.cc:2888: void LargeObjectSpace::PrepareForDeserialization(int
> large_objects_total_size) {
> This method should not be part of large object space. Please move it to heap.

I hope I sufficiently addressed your comments. I folded tracking of large object
allocations into the tracking of allocation in other spaces, which seems
cleaner. I also did what I was too lazy to do: I enabled large objects also for
the startup snapshot, which was just adding two new fields in a couple of files.

Please take another look.

[Hannes Payer (out of office), 2014-09-24 21:27:51]

lgtm

https://codereview.chromium.org/581223004/diff/40001/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/581223004/diff/40001/src/heap/spaces.cc#newco...
src/heap/spaces.cc:2888: void LargeObjectSpace::PrepareForDeserialization(int
large_objects_total_size) {
Please delete this method.

https://codereview.chromium.org/581223004/diff/40001/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/581223004/diff/40001/src/heap/spaces.h#newcod...
src/heap/spaces.h:2731: void PrepareForDeserialization(int
large_objects_total_size);
Please delete this method.

[Yang, 2014-09-25 07:32:00]

On 2014/09/24 21:27:51, Hannes Payer wrote:
> lgtm
> 
> https://codereview.chromium.org/581223004/diff/40001/src/heap/spaces.cc
> File src/heap/spaces.cc (right):
> 
>
https://codereview.chromium.org/581223004/diff/40001/src/heap/spaces.cc#newco...
> src/heap/spaces.cc:2888: void LargeObjectSpace::PrepareForDeserialization(int
> large_objects_total_size) {
> Please delete this method.
> 
> https://codereview.chromium.org/581223004/diff/40001/src/heap/spaces.h
> File src/heap/spaces.h (right):
> 
>
https://codereview.chromium.org/581223004/diff/40001/src/heap/spaces.h#newcod...
> src/heap/spaces.h:2731: void PrepareForDeserialization(int
> large_objects_total_size);
> Please delete this method.

Thanks! I removed them.

[Yang, 2014-09-25 07:32:34]

Committed patchset #4 (id:60001) manually as 24204 (presubmit successful).