Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 581173004: Fix target arch for x86 bots. (Closed)

Created:
6 years, 3 months ago by navabi
Modified:
6 years, 3 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix target arch for x86 bots. The target_arch should be ia32 for x86 builders. This is causing the x86 try and fyi bots to fail during runhooks because it doesnt match a case in common.gypi. BUG=359644 TBR=cmp@chromium.org Committed: https://crrev.com/99fa5464cb1b1ba9af0dee4438f182de5c0847ea Cr-Commit-Position: refs/heads/master@{#295644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/buildbot/bb_run_bot.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Nico
lgtm
6 years, 3 months ago (2014-09-18 22:52:00 UTC) #3
aurimas (slooooooooow)
LGTM
6 years, 3 months ago (2014-09-19 00:28:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581173004/1
6 years, 3 months ago (2014-09-19 01:01:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12045)
6 years, 3 months ago (2014-09-19 01:14:00 UTC) #10
aurimas (slooooooooow)
craigdh@chromium.org OWNERS review.
6 years, 3 months ago (2014-09-19 01:17:45 UTC) #12
navabi
craigdh is gone as is every single other OWNER besides myself. We should add jbudorick ...
6 years, 3 months ago (2014-09-19 02:34:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581173004/1
6 years, 3 months ago (2014-09-19 02:35:51 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as bcc15d0896b34f3199a9852c8c373ccef8687a33
6 years, 3 months ago (2014-09-19 02:40:40 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 02:41:41 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99fa5464cb1b1ba9af0dee4438f182de5c0847ea
Cr-Commit-Position: refs/heads/master@{#295644}

Powered by Google App Engine
This is Rietveld 408576698