Issue 581163002: Removed unused argument and GetPrintCanvasSize.

Issue 581163002: Removed unused argument and GetPrintCanvasSize. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 3 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_rot

Project:
chromium

Visibility:
Public.

Removed unused argument and GetPrintCanvasSize. Committed: https://crrev.com/91cbfa0c728e460fbc02c79a52755251356bb46f Cr-Commit-Position: refs/heads/master@{#295532}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -37 lines)			Patch
M	chrome/renderer/printing/print_web_view_helper.h	View	1	2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper.cc	View	1	6 chunks	+4 lines, -19 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper_linux.cc	View		4 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper_mac.mm	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper_pdf_win.cc	View		4 chunks	+1 line, -5 lines	0 comments	Download

Total messages: 14 (4 generated)

Lei Zhang

lgtm Are there any GetPrintCanvasSize() callers left? If not, remove it too?

6 years, 3 months ago (2014-09-18 18:38:28 UTC) #4

Vitaly Buka (NO REVIEWS)

On 2014/09/18 18:38:28, Lei Zhang wrote: > lgtm > > Are there any GetPrintCanvasSize() callers ...

6 years, 3 months ago (2014-09-18 18:40:36 UTC) #5

Vitaly Buka (NO REVIEWS)

On 2014/09/18 18:40:36, Vitaly Buka wrote: > On 2014/09/18 18:38:28, Lei Zhang wrote: > > ...

6 years, 3 months ago (2014-09-18 18:41:31 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581163002/20001

6 years, 3 months ago (2014-09-18 18:44:57 UTC) #12

commit-bot: I haz the power

Committed patchset #2 (id:20001) as b6d8726cee7f85b7c97402dc7d420fda5a392bc2

6 years, 3 months ago (2014-09-18 19:42:24 UTC) #13

commit-bot: I haz the power

6 years, 3 months ago (2014-09-18 19:43:00 UTC) #14

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/91cbfa0c728e460fbc02c79a52755251356bb46f
Cr-Commit-Position: refs/heads/master@{#295532}