Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: Source/devtools/front_end/toolbox/MediaQueryInspector.js

Issue 581133002: DevTools: polish the MQ ruler, move zoom controls to the top. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/toolbox/MediaQueryInspector.js
diff --git a/Source/devtools/front_end/toolbox/MediaQueryInspector.js b/Source/devtools/front_end/toolbox/MediaQueryInspector.js
index 4c8676f0ddb791db1974c5dd402c8dba7f458178..88b7ce1e0ad33ad62b634dfd3ca8f6cd7b1903b2 100644
--- a/Source/devtools/front_end/toolbox/MediaQueryInspector.js
+++ b/Source/devtools/front_end/toolbox/MediaQueryInspector.js
@@ -320,14 +320,11 @@ WebInspector.MediaQueryInspector.prototype = {
for (var i = children.length - 1; i >= 0; --i) {
if (found) {
children[i].classList.remove("media-inspector-marker-highlight");
- children[i].classList.remove("media-inspector-marker-under-highlighted");
} else if (children[i] === marker) {
children[i].classList.add("media-inspector-marker-highlight");
- children[i].classList.remove("media-inspector-marker-under-highlighted");
found = true;
} else {
children[i].classList.remove("media-inspector-marker-highlight");
- children[i].classList.add("media-inspector-marker-under-highlighted");
}
}
},
@@ -373,18 +370,20 @@ WebInspector.MediaQueryInspector.prototype = {
if (typeof widthPixelValue === "number")
markerElement.style.width = widthPixelValue + "px";
- if (model.maxWidthExpression()) {
- var labelClass = model.section() === WebInspector.MediaQueryInspector.Section.MinMax ? "media-inspector-label-left" : "media-inspector-label-right";
- var labelContainer = markerElement.createChild("div", "media-inspector-marker-label-container media-inspector-marker-label-container-right");
- labelContainer.createChild("div", "media-inspector-marker-serif");
- labelContainer.createChild("span", "media-inspector-marker-label " + labelClass).textContent = model.maxWidthExpression().computedLength() + "px";
- }
-
if (model.minWidthExpression()) {
var labelClass = model.section() === WebInspector.MediaQueryInspector.Section.MinMax ? "media-inspector-label-right" : "media-inspector-label-left";
var labelContainer = markerElement.createChild("div", "media-inspector-marker-label-container media-inspector-marker-label-container-left");
- labelContainer.createChild("div", "media-inspector-marker-serif");
labelContainer.createChild("span", "media-inspector-marker-label " + labelClass).textContent = model.minWidthExpression().computedLength() + "px";
+ markerElement.title = model.minWidthExpression().computedLength() + "px";
+ if (model.maxWidthExpression())
+ markerElement.title += WebInspector.UIString(" \u2014 ");
+ }
+
+ if (model.maxWidthExpression()) {
+ var labelClass = model.section() === WebInspector.MediaQueryInspector.Section.MinMax ? "media-inspector-label-left" : "media-inspector-label-right";
+ var labelContainer = markerElement.createChild("div", "media-inspector-marker-label-container media-inspector-marker-label-container-right");
+ labelContainer.createChild("span", "media-inspector-marker-label " + labelClass).textContent = model.maxWidthExpression().computedLength() + "px";
+ markerElement.title += model.maxWidthExpression().computedLength() + "px";
}
return markerElement;

Powered by Google App Engine
This is Rietveld 408576698