Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 581053002: Bookmark context menu should appear over the bookmark folder menu. (Closed)

Created:
6 years, 3 months ago by Gaja
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Bookmark context menu should appear over the bookmark folder menu. If user right clicks immediately on entering a bookmark button, then open the folder without delay so that context menu appears over the folder menu. BUG=168758 R=asvitkine@chromium.org TEST= 1. Add a bookmark folder to Bookmarks Bar (folder1). 2. Add a subfolder (folder2) inside folder1. 3. Add few bookmarks to folder2. 4. Click on folder1 and immediately right click on folder2 and observe. 5. Context Menu should appear over the folder menu (folder contents window). Committed: https://crrev.com/33900453c57e5f669044cc5b8dafc093ab62287a Cr-Commit-Position: refs/heads/master@{#295655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Gaja
@asvitkine Please take a look. Thanks. And, does this require a unit test?
6 years, 3 months ago (2014-09-18 06:36:24 UTC) #1
Alexei Svitkine (slow)
LGTM
6 years, 3 months ago (2014-09-18 13:38:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581053002/1
6 years, 3 months ago (2014-09-18 15:17:45 UTC) #4
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-18 17:18:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581053002/1
6 years, 3 months ago (2014-09-18 17:45:42 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-18 19:47:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581053002/1
6 years, 3 months ago (2014-09-19 02:49:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as ee85a098a490acd6fdb232c2847380be1e178f93
6 years, 3 months ago (2014-09-19 03:46:51 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 03:47:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33900453c57e5f669044cc5b8dafc093ab62287a
Cr-Commit-Position: refs/heads/master@{#295655}

Powered by Google App Engine
This is Rietveld 408576698