Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 581023003: [SystemDisplayAPI] Observe display change on linux/win/mac as well (Closed)

Created:
6 years, 3 months ago by oshima
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

This API wasn't working on non chromeos platforms because it wasn't observing the display change. BUG=316217 TEST=install the test app attached in the bug and change the scree resolution. Committed: https://crrev.com/31eac8332a606e63d35756ad2106d545bea90677 Cr-Commit-Position: refs/heads/master@{#295733}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/extensions/display_info_provider_aura.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_mac.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_win.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
oshima
6 years, 3 months ago (2014-09-18 23:04:47 UTC) #2
mlamouri (slow - plz ping)
Great to see my Screen Orientation changes having a positive effect on other APIs! :) ...
6 years, 3 months ago (2014-09-19 08:46:44 UTC) #3
oshima
scheib@ -> owners review
6 years, 3 months ago (2014-09-19 14:35:44 UTC) #5
scheib
lgtm
6 years, 3 months ago (2014-09-19 15:02:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581023003/20001
6 years, 3 months ago (2014-09-19 17:17:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7c70bcfafa3432223aafe7e265c6632d249bb3e1
6 years, 3 months ago (2014-09-19 18:05:26 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 18:06:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31eac8332a606e63d35756ad2106d545bea90677
Cr-Commit-Position: refs/heads/master@{#295733}

Powered by Google App Engine
This is Rietveld 408576698