Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 581003002: Fix some chrome://settings paddings (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix some chrome://settings paddings BUG=none Committed: https://crrev.com/3558ad6e60006a99741e05f781ffb868ef1dcfc3 Cr-Commit-Position: refs/heads/master@{#295420}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/resources/options/browser_options.html View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/webui/resources/css/widgets.css View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
Evan Stade
https://codereview.chromium.org/581003002/diff/1/ui/webui/resources/css/widgets.css File ui/webui/resources/css/widgets.css (right): https://codereview.chromium.org/581003002/diff/1/ui/webui/resources/css/widgets.css#newcode83 ui/webui/resources/css/widgets.css:83: bottom: 1px; we actually checked this on every single ...
6 years, 3 months ago (2014-09-18 00:58:46 UTC) #2
Dan Beam
lgtm
6 years, 3 months ago (2014-09-18 01:39:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/581003002/1
6 years, 3 months ago (2014-09-18 01:39:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1965ef0d3726cc0b8e3105a61f403407855ef5f0
6 years, 3 months ago (2014-09-18 05:33:45 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 05:34:17 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3558ad6e60006a99741e05f781ffb868ef1dcfc3
Cr-Commit-Position: refs/heads/master@{#295420}

Powered by Google App Engine
This is Rietveld 408576698