Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 580973002: Revert of Clean up GestureEventDetails constructors and fix unit tests (Closed)

Created:
6 years, 3 months ago by Dan Beam
Modified:
6 years, 3 months ago
Reviewers:
sky, lanwei
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dcheng, yukishiino+watch_chromium.org, ben+aura_chromium.org, Ilya Sherman, tdanderson+views_chromium.org, benquan, jdduke+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, tdresser+watch_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, ben+corewm_chromium.org, ben+views_chromium.org, rouslan+autofillwatch_chromium.org, tfarina, stevenjb+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, James Su, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up GestureEventDetails constructors and fix unit tests (patchset #3 id:60001 of https://codereview.chromium.org/573963005/) Reason for revert: this may have broken wm_unittests on XP Tests (3): https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(3)/builds/28989 WindowAnimationsTest.HideAnimationDetachLayers (run #1): [ RUN ] WindowAnimationsTest.HideAnimationDetachLayers c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false) Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating() Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate() Actual: true Expected: false c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B9D8 vs 0017B9D8 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer) Actual: 1 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer) Actual: 0 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end() Actual: false Expected: true [ FAILED ] WindowAnimationsTest.HideAnimationDetachLayers (141 ms) WindowAnimationsTest.HideAnimationDetachLayers (run #2): [ RUN ] WindowAnimationsTest.HideAnimationDetachLayers c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false) Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating() Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate() Actual: true Expected: false c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer) Actual: 1 Expected: 2 c:\b\build\slaveWindowAnimationsTest.HideAnimationDetachLayers (run #1): [ RUN ] WindowAnimationsTest.HideAnimationDetachLayers c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false) Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating() Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate() Actual: true Expected: false c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B9D8 vs 0017B9D8 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer) Actual: 1 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer) Actual: 0 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end() Actual: false Expected: true [ FAILED ] WindowAnimationsTest.HideAnimationDetachLayers (141 ms) WindowAnimationsTest.HideAnimationDetachLayers (run #2): [ RUN ] WindowAnimationsTest.HideAnimationDetachLayers c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false) Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating() Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate() Actual: true Expected: false c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer) Actual: 1 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer) Actual: 0 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end() Actual: false Expected: true [ FAILED ] WindowAnimationsTest.HideAnimationDetachLayers (94 ms) WindowAnimationsTest.HideAnimationDetachLayers (run #3): [ RUN ] WindowAnimationsTest.HideAnimationDetachLayers c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false) Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating() Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate() Actual: true Expected: false c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer) Actual: 1 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer) Actual: 0 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end() Actual: false Expected: true [ FAILED ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms) WindowAnimationsTest.HideAnimationDetachLayers (run #4): [ RUN ] WindowAnimationsTest.HideAnimationDetachLayers c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false) Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating() Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate() Actual: true Expected: false c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer) Actual: 1 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer) Actual: 0 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end() Actual: false Expected: true [ FAILED ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms)\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer) Actual: 0 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end() Actual: false Expected: true [ FAILED ] WindowAnimationsTest.HideAnimationDetachLayers (94 ms) WindowAnimationsTest.HideAnimationDetachLayers (run #3): [ RUN ] WindowAnimationsTest.HideAnimationDetachLayers c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false) Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating() Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate() Actual: true Expected: false c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer) Actual: 1 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer) Actual: 0 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end() Actual: false Expected: true [ FAILED ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms) WindowAnimationsTest.HideAnimationDetachLayers (run #4): [ RUN ] WindowAnimationsTest.HideAnimationDetachLayers c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149): error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(), false) Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150): error: Value of: animating_layer->GetAnimator()->is_animating() Actual: false Expected: true c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151): error: Value of: animating_layer->delegate() Actual: true Expected: false c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155): error: Expected: (animating_window->layer()) != (animating_layer), actual: 0017B318 vs 0017B318 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171): error: Value of: GetLayerZPosition(animating_layer) Actual: 1 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error: Value of: GetLayerZPosition(animating_layer) Actual: 0 Expected: 2 c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188): error: Value of: std::find(parent->layer()->children().begin(), parent->layer()->children().end(), animating_layer) == parent->layer()->children().end() Actual: false Expected: true [ FAILED ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms) Original issue's description: > Clean up GestureEventDetails constructors and fix unit tests. > > A new version of Issue 565583005: Clean up GestureEventDetails > constructors > https://codereview.chromium.org/565583005/ > > BUG=350942 > > TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org > > Committed: https://crrev.com/874611d5ab5b879648682c1ea41062bebc9c95e5 > Cr-Commit-Position: refs/heads/master@{#295144} > > Committed: https://crrev.com/66e0c057b87824c6e6928f359fa56a8ee45ae6e2 > Cr-Commit-Position: refs/heads/master@{#295296} > > Committed: https://crrev.com/9ec877c2d256a538b1c9af2fbed736aad8406e66 > Cr-Commit-Position: refs/heads/master@{#295329} TBR=sky@chromium.org,lanwei@chromium.org NOTREECHECKS=true NOTRY=true BUG=350942 Committed: https://crrev.com/8c2ece8a0b3ebda1ceebd8fda2939d23b85848f9 Cr-Commit-Position: refs/heads/master@{#295353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Clean up GestureEventDetails constructors and fix unit tests
6 years, 3 months ago (2014-09-17 21:47:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580973002/1
6 years, 3 months ago (2014-09-17 21:48:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 638fa83d8f787a68bda84f08eef3df20eaae75fe
6 years, 3 months ago (2014-09-17 21:49:22 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 21:49:55 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8c2ece8a0b3ebda1ceebd8fda2939d23b85848f9
Cr-Commit-Position: refs/heads/master@{#295353}

Powered by Google App Engine
This is Rietveld 408576698