Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: chrome/browser/devtools/device/usb/android_usb_browsertest.cc

Issue 580963002: Add a service to track devices selected by the user. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed all of scheib@'s feedback. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/saved_devices_service_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/usb/android_usb_browsertest.cc
diff --git a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
index 585254680e45d0664f320e6afe14924a1080f05b..2ae1c14fe8ff18858d6e397a9ad58accd69ac333 100644
--- a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
+++ b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
@@ -120,7 +120,7 @@ class MockUsbDeviceHandle : public UsbDeviceHandle {
virtual void Close() OVERRIDE { device_ = NULL; }
- bool ClaimInterface(const int interface_number) {
+ bool ClaimInterface(int interface_number) {
if (device_->claimed_interfaces_.find(interface_number) !=
device_->claimed_interfaces_.end())
return false;
@@ -129,7 +129,7 @@ class MockUsbDeviceHandle : public UsbDeviceHandle {
return true;
}
- bool ReleaseInterface(const int interface_number) {
+ bool ReleaseInterface(int interface_number) {
if (device_->claimed_interfaces_.find(interface_number) ==
device_->claimed_interfaces_.end())
return false;
@@ -138,9 +138,8 @@ class MockUsbDeviceHandle : public UsbDeviceHandle {
return true;
}
- virtual bool SetInterfaceAlternateSetting(
- const int interface_number,
- const int alternate_setting) OVERRIDE {
+ virtual bool SetInterfaceAlternateSetting(int interface_number,
+ int alternate_setting) OVERRIDE {
return true;
}
@@ -162,22 +161,22 @@ class MockUsbDeviceHandle : public UsbDeviceHandle {
}
// Async IO. Can be called on any thread.
- virtual void ControlTransfer(const UsbEndpointDirection direction,
- const TransferRequestType request_type,
- const TransferRecipient recipient,
- const uint8 request,
- const uint16 value,
- const uint16 index,
+ virtual void ControlTransfer(UsbEndpointDirection direction,
+ TransferRequestType request_type,
+ TransferRecipient recipient,
+ uint8 request,
+ uint16 value,
+ uint16 index,
net::IOBuffer* buffer,
- const size_t length,
- const unsigned int timeout,
+ size_t length,
+ unsigned int timeout,
const UsbTransferCallback& callback) OVERRIDE {}
- virtual void BulkTransfer(const UsbEndpointDirection direction,
- const uint8 endpoint,
+ virtual void BulkTransfer(UsbEndpointDirection direction,
+ uint8 endpoint,
net::IOBuffer* buffer,
- const size_t length,
- const unsigned int timeout,
+ size_t length,
+ unsigned int timeout,
const UsbTransferCallback& callback) OVERRIDE {
if (direction == device::USB_DIRECTION_OUTBOUND) {
if (remaining_body_length_ == 0) {
@@ -304,22 +303,22 @@ class MockUsbDeviceHandle : public UsbDeviceHandle {
query.size));
}
- virtual void InterruptTransfer(const UsbEndpointDirection direction,
- const uint8 endpoint,
+ virtual void InterruptTransfer(UsbEndpointDirection direction,
+ uint8 endpoint,
net::IOBuffer* buffer,
- const size_t length,
- const unsigned int timeout,
+ size_t length,
+ unsigned int timeout,
const UsbTransferCallback& callback) OVERRIDE {
}
virtual void IsochronousTransfer(
- const UsbEndpointDirection direction,
- const uint8 endpoint,
+ UsbEndpointDirection direction,
+ uint8 endpoint,
net::IOBuffer* buffer,
- const size_t length,
- const unsigned int packets,
- const unsigned int packet_length,
- const unsigned int timeout,
+ size_t length,
+ unsigned int packets,
+ unsigned int packet_length,
+ unsigned int timeout,
const UsbTransferCallback& callback) OVERRIDE {}
protected:
« no previous file with comments | « apps/saved_devices_service_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698