Ignore uninteresting events when recording the last errors to report

extensions/browser/api/cast_channel/logger_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/simple_test_tick_clock.h"
 #include "extensions/browser/api/cast_channel/cast_auth_util.h"
 #include "extensions/browser/api/cast_channel/logger.h"
 #include "extensions/browser/api/cast_channel/logger_util.h"
+#include "net/base/net_errors.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/zlib/zlib.h"
 
 namespace extensions {
 namespace core_api {
 namespace cast_channel {
 
 const int kTestNssErrorCode = -8164;
 
 using proto::AggregatedSocketEvent;
@@ skipping 156 matching lines @@
       EXPECT_EQ(EventType::AUTH_CHALLENGE_REPLY, event.type());
       EXPECT_EQ(6, event.timestamp_micros());
       EXPECT_EQ(proto::CHALLENGE_REPLY_ERROR_NSS_CERT_PARSING_FAILED,
                 event.challenge_reply_error_type());
       EXPECT_FALSE(event.has_net_return_value());
       EXPECT_EQ(kTestNssErrorCode, event.nss_error_code());
     }
   }
 }
 
+TEST_F(CastChannelLoggerTest, UninterestingEventsIgnored) {
+  logger_->LogSocketEventWithRv(1, EventType::CAST_SOCKET_CREATED, net::OK);
+  // CAST_SOCKET_CREATED is interesting.
+  LastErrors last_errors = logger_->GetLastErrors(1);
+  EXPECT_EQ(last_errors.event_type, proto::CAST_SOCKET_CREATED);
+  EXPECT_EQ(last_errors.net_return_value, net::OK);
+
+  // These four events and net return value are not interesting, and are not
+  // reported in last_errors.
+  clock_->Advance(base::TimeDelta::FromMicroseconds(1));
+  logger_->LogSocketEventWithRv(1,
+                                EventType::READY_STATE_CHANGED,
+                                net::ERR_IO_PENDING);
+  clock_->Advance(base::TimeDelta::FromMicroseconds(1));
+  logger_->LogSocketEvent(1, EventType::ERROR_STATE_CHANGED);
+  clock_->Advance(base::TimeDelta::FromMicroseconds(1));
+  logger_->LogSocketEvent(1, EventType::NOTIFY_ON_MESSAGE);
+  clock_->Advance(base::TimeDelta::FromMicroseconds(1));
+  logger_->LogSocketEvent(1, EventType::NOTIFY_ON_ERROR);
+  last_errors = logger_->GetLastErrors(1);
+  EXPECT_EQ(last_errors.event_type, proto::CAST_SOCKET_CREATED);
+  EXPECT_EQ(last_errors.net_return_value, net::OK);
+
+  // Log an interesting event again.
+  clock_->Advance(base::TimeDelta::FromMicroseconds(1));
+  logger_->LogSocketEventWithRv(1, EventType::CONNECT_FAILED, net::ERR_FAILED);
+  last_errors = logger_->GetLastErrors(1);
+  EXPECT_EQ(last_errors.event_type, proto::CONNECT_FAILED);
+  EXPECT_EQ(last_errors.net_return_value, net::ERR_FAILED);
+}
+
 TEST_F(CastChannelLoggerTest, LogSocketReadWrite) {
   logger_->LogSocketEventWithRv(1, EventType::SOCKET_READ, 50);
   clock_->Advance(base::TimeDelta::FromMicroseconds(1));
   logger_->LogSocketEventWithRv(1, EventType::SOCKET_READ, 30);
   clock_->Advance(base::TimeDelta::FromMicroseconds(1));
   logger_->LogSocketEventWithRv(1, EventType::SOCKET_READ, -1);
   clock_->Advance(base::TimeDelta::FromMicroseconds(1));
   logger_->LogSocketEventWithRv(1, EventType::SOCKET_WRITE, 20);
   clock_->Advance(base::TimeDelta::FromMicroseconds(1));
 
@@ skipping 74 matching lines @@
 
   log = GetLog();
   ASSERT_TRUE(log.get() != NULL);
 
   EXPECT_EQ(0, log->aggregated_socket_event_size());
 }
 
 }  // namespace cast_channel
 }  // namespace api
 }  // namespace extensions