Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 580903007: remove a couple more <label> for= uses (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove a couple more <label> for= uses BUG=409938 Committed: https://crrev.com/9e5e3f4060f759384d224a44c41d3f4a328b86d8 Cr-Commit-Position: refs/heads/master@{#295416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M chrome/browser/resources/options/certificate_backup_overlay.html View 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
testable if you type CertificateBackOverlay.show() in the console.
6 years, 3 months ago (2014-09-18 01:16:13 UTC) #2
Dan Beam
lgtm
6 years, 3 months ago (2014-09-18 01:40:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580903007/1
6 years, 3 months ago (2014-09-18 02:48:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 870791a9ac6d9e20d263601b9b96028111976004
6 years, 3 months ago (2014-09-18 04:53:27 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 04:54:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e5e3f4060f759384d224a44c41d3f4a328b86d8
Cr-Commit-Position: refs/heads/master@{#295416}

Powered by Google App Engine
This is Rietveld 408576698