Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 580903003: Move Touch Feedback flag to ui_base_switches (Closed)

Created:
6 years, 3 months ago by jonross
Modified:
6 years, 2 months ago
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move Touch Feedback flag to ui_base_switches Move flag for touch feedback experiments to ui_base_switches from ash_switches. Update the classes currently using the ash switch. This will allow for the experiments which are on components under ui/ BUG=398398 Committed: https://crrev.com/37f21b8e03b0647492f24606cbd87ba0647374e9 Cr-Commit-Position: refs/heads/master@{#297246}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re-add to histogram #

Patch Set 3 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -37 lines) Patch
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/shelf/app_list_button.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/shelf/app_list_button.cc View 5 chunks +4 lines, -6 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_background_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 5 chunks +2 lines, -8 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/ui_base_switches_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_switches_util.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (9 generated)
jonross
I plan to land the move of the switch, before updating all the CLs currently ...
6 years, 3 months ago (2014-09-17 21:27:02 UTC) #2
flackr
LGTM. Looks much cleaner, thanks for moving tracking the result into a helper function! Might ...
6 years, 3 months ago (2014-09-17 21:34:45 UTC) #3
jonross
6 years, 3 months ago (2014-09-17 21:40:21 UTC) #5
jonross
Hi Stefan, Could you provide an owner review for the changes to ash/shelf and ash/system/tray? ...
6 years, 3 months ago (2014-09-17 21:41:21 UTC) #6
jonross
Hi Ben, I'm working on some touch feedback experiments. We want to move our current ...
6 years, 3 months ago (2014-09-17 21:45:00 UTC) #8
jonross
Hi Alexei, Could you provide an owner review to tools/metrics/histograms/histograms.xml. I've updated it to account ...
6 years, 3 months ago (2014-09-17 21:46:21 UTC) #10
Mr4D (OOO till 08-26)
lgtm for ash/system/tray
6 years, 3 months ago (2014-09-18 23:27:34 UTC) #11
Alexei Svitkine (slow)
https://codereview.chromium.org/580903003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/580903003/diff/1/tools/metrics/histograms/histograms.xml#oldcode44612 tools/metrics/histograms/histograms.xml:44612: - <int value="1163255347" label="ash-enable-touch-view-touch-feedback"/> Please don't remove obsolete entries ...
6 years, 3 months ago (2014-09-19 04:17:30 UTC) #12
jonross
https://codereview.chromium.org/580903003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/580903003/diff/1/tools/metrics/histograms/histograms.xml#oldcode44612 tools/metrics/histograms/histograms.xml:44612: - <int value="1163255347" label="ash-enable-touch-view-touch-feedback"/> On 2014/09/19 04:17:30, Alexei Svitkine ...
6 years, 3 months ago (2014-09-19 13:41:51 UTC) #13
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-19 14:08:05 UTC) #14
jonross
Hi Ben, Would you be able to provide an owner's review for my changes to ...
6 years, 2 months ago (2014-09-25 14:48:31 UTC) #15
jonross
sky@chromium.org: I'm working on some touch feedback experiments. We want to move our current switch ...
6 years, 2 months ago (2014-09-29 15:03:52 UTC) #18
sky
ui LGTM
6 years, 2 months ago (2014-09-29 18:05:54 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580903003/20001
6 years, 2 months ago (2014-09-29 18:10:23 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/19922)
6 years, 2 months ago (2014-09-29 18:28:35 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580903003/40001
6 years, 2 months ago (2014-09-29 19:06:54 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001) as d42577806f2d8f7a5828f9e3794dd6af78d01e0c
6 years, 2 months ago (2014-09-29 20:31:43 UTC) #26
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 20:32:23 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/37f21b8e03b0647492f24606cbd87ba0647374e9
Cr-Commit-Position: refs/heads/master@{#297246}

Powered by Google App Engine
This is Rietveld 408576698