Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 580813002: Remove TSan annotations from base/, because ThreadSanitizer v2 doesn't need base::subtle to be anno… (Closed)

Created:
6 years, 3 months ago by Alexander Potapenko
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove TSan annotations from base/ , because ThreadSanitizer v2 doesn't need base::subtle to be annotated. We can't drop the dependency on libdynamic_annotations yet, because some code calls RunningOnValgrind(). Also remove the unused dynamic_annotations.h headers from base/ and add one to content/test/, which uses RunningOnValgrind(). BUG=349861 R=ajwong@chromium.org,phajdan.jr@chromium.org Committed: https://crrev.com/3a065495f1e4edd6e8d9b510340a927a917a91e6 Cr-Commit-Position: refs/heads/master@{#296265}

Patch Set 1 #

Patch Set 2 : Revert base.gyp, someone's using RunningOnValgrind() #

Patch Set 3 : IWYU for RunningOnValgrind() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M base/atomic_ref_count.h View 4 chunks +0 lines, -11 lines 0 comments Download
M base/lazy_instance.h View 2 chunks +0 lines, -8 lines 0 comments Download
M base/lazy_instance.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M base/vlog_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/blink_test_environment.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Alexander Potapenko
Nico, Paweł, may I ask you to take a look? The failures on the TSan ...
6 years, 3 months ago (2014-09-18 08:52:31 UTC) #2
Paweł Hajdan Jr.
content/test LGTM
6 years, 3 months ago (2014-09-18 23:52:19 UTC) #3
Alexander Potapenko
+ajwong Albert, can you please review the base/ bits here?
6 years, 3 months ago (2014-09-22 14:13:41 UTC) #5
Nico
lgtm (note: you sent this to "thakis@chomium.org" (missing an 'r'), so I never received an ...
6 years, 3 months ago (2014-09-23 16:51:55 UTC) #7
Alexander Potapenko
On 2014/09/23 16:51:55, Nico (hiding) wrote: > lgtm > > (note: you sent this to ...
6 years, 3 months ago (2014-09-23 17:02:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580813002/40001
6 years, 3 months ago (2014-09-23 17:59:17 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e525bd47f4918a87d64615e7207a9252193f9303
6 years, 3 months ago (2014-09-23 21:50:22 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3a065495f1e4edd6e8d9b510340a927a917a91e6 Cr-Commit-Position: refs/heads/master@{#296265}
6 years, 3 months ago (2014-09-23 21:50:59 UTC) #15
awong
6 years, 3 months ago (2014-09-23 22:30:13 UTC) #17
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698