chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc - Issue 580713002: Close the App Info Dialog if the app or profile becomes invalid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

Issue 580713002: Close the App Info Dialog if the app or profile becomes invalid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small fixes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

index 2c5e0f4a5812f3e0f8e3e3dfa0f4a9c853af887b..2858d0957e07891ee7ced2dfd2298608c62111a2 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

@@ -26,7 +26,6 @@

#include "ui/views/layout/grid_layout.h"

#include "ui/views/layout/layout_constants.h"

#include "ui/views/view.h"

-#include "ui/views/widget/widget.h"

AppInfoPermissionsPanel::AppInfoPermissionsPanel(

Profile* profile,

@@ -264,7 +263,7 @@ void AppInfoPermissionsPanel::RevokeFilePermissions() {

apps::SavedFilesService::Get(profile_)->ClearQueue(app_);

apps::AppLoadService::Get(profile_)->RestartApplicationIfRunning(app_->id());

- GetWidget()->Close();

+ Close();

}

const std::vector<base::string16> AppInfoPermissionsPanel::GetRetainedDevices()

@@ -277,5 +276,5 @@ void AppInfoPermissionsPanel::RevokeDevicePermissions() {

extensions::DevicePermissionsManager::Get(profile_)->Clear(app_->id());

apps::AppLoadService::Get(profile_)->RestartApplicationIfRunning(app_->id());

- GetWidget()->Close();

+ Close();

}