Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 580683003: Include content_shell.pak for linux and windows swarming. (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Include content_shell.pak for linux and windows swarming. Apparently these are also required for the swarming phase of tests. BUG=312586 R=jochen@chromium.org Committed: https://crrev.com/968b94fac3690032c9ceb66af4cb49d0e9b0a419 Cr-Commit-Position: refs/heads/master@{#295717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/content_browsertests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M content/content_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
vivekg
PTAL, thanks!
6 years, 3 months ago (2014-09-17 05:27:50 UTC) #2
Mike West
Non-OWNER's LGTM. You'll still need someone like Jochen to stamp the patch, of course. I've ...
6 years, 3 months ago (2014-09-17 08:20:35 UTC) #4
vivekg
On 2014/09/17 at 08:20:35, mkwst wrote: > Non-OWNER's LGTM. You'll still need someone like Jochen ...
6 years, 3 months ago (2014-09-18 08:20:56 UTC) #5
vivekg
On 2014/09/18 at 08:20:56, vivekg_ wrote: > On 2014/09/17 at 08:20:35, mkwst wrote: > > ...
6 years, 3 months ago (2014-09-18 08:21:26 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-19 11:27:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580683003/1
6 years, 3 months ago (2014-09-19 11:54:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 987118edd7c3f9436b70aff28eb6c2cb895c2624
6 years, 3 months ago (2014-09-19 16:14:56 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 16:15:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/968b94fac3690032c9ceb66af4cb49d0e9b0a419
Cr-Commit-Position: refs/heads/master@{#295717}

Powered by Google App Engine
This is Rietveld 408576698