Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 580673002: Revert "If duration of media source is unknown then return NaN." (Closed)

Created:
6 years, 3 months ago by tonyg
Modified:
6 years, 3 months ago
Reviewers:
qinmin
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "If duration of media source is unknown then return NaN." This reverts commit 536be704e6ff71001c7f402e18956204bf76f8bf. Revert "Fix an issue that video is not seekable" This reverts commit 21f1f757864d7ec360ee1c7a00a6cb31d7af1231. The first causes the tough_video_cases benchmark to hang and the second depends on it. Details in bug. BUG=412897 TBR=qinmin@chromium.org Committed: https://crrev.com/7e63a0151fb0026af444b31332de4fd293f6fb1d Cr-Commit-Position: refs/heads/master@{#295282}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 5 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580673002/1
6 years, 3 months ago (2014-09-17 03:39:35 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/56927) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/16195) ios_dbg_simulator ...
6 years, 3 months ago (2014-09-17 03:42:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580673002/20001
6 years, 3 months ago (2014-09-17 14:59:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5f3af9a2fe6a475392e54bd5af548a59feedb307
6 years, 3 months ago (2014-09-17 15:56:04 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 15:56:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e63a0151fb0026af444b31332de4fd293f6fb1d
Cr-Commit-Position: refs/heads/master@{#295282}

Powered by Google App Engine
This is Rietveld 408576698