Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 580643002: [Clean-up] Prune unnecessary dependencies from //device/bluetooth. (Closed)

Created:
6 years, 3 months ago by Ilya Sherman
Modified:
6 years, 2 months ago
Reviewers:
keybuk, armansito
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Clean-up] Prune unnecessary dependencies from //device/bluetooth. BUG=none TEST=none R=keybuk@chromium.org Committed: https://crrev.com/16e2f2806a4e505ed1941e2720339499aebea4ea Cr-Commit-Position: refs/heads/master@{#297297}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M device/bluetooth/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +0 lines, -4 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
Ilya Sherman
6 years, 3 months ago (2014-09-17 00:04:10 UTC) #1
Ilya Sherman
+Arman
6 years, 2 months ago (2014-09-26 04:03:22 UTC) #3
armansito
https://codereview.chromium.org/580643002/diff/1/device/bluetooth/bluetooth.gyp File device/bluetooth/bluetooth.gyp (right): https://codereview.chromium.org/580643002/diff/1/device/bluetooth/bluetooth.gyp#newcode17 device/bluetooth/bluetooth.gyp:17: '../../ui/base/ui_base.gyp:ui_base', What do we use ui_base for? Should this ...
6 years, 2 months ago (2014-09-26 04:10:39 UTC) #4
Ilya Sherman
https://codereview.chromium.org/580643002/diff/1/device/bluetooth/bluetooth.gyp File device/bluetooth/bluetooth.gyp (right): https://codereview.chromium.org/580643002/diff/1/device/bluetooth/bluetooth.gyp#newcode17 device/bluetooth/bluetooth.gyp:17: '../../ui/base/ui_base.gyp:ui_base', On 2014/09/26 04:10:39, armansito wrote: > What do ...
6 years, 2 months ago (2014-09-26 04:29:21 UTC) #5
armansito
On 2014/09/26 04:29:21, Ilya Sherman wrote: > https://codereview.chromium.org/580643002/diff/1/device/bluetooth/bluetooth.gyp > File device/bluetooth/bluetooth.gyp (right): > > https://codereview.chromium.org/580643002/diff/1/device/bluetooth/bluetooth.gyp#newcode17 ...
6 years, 2 months ago (2014-09-29 18:17:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580643002/1
6 years, 2 months ago (2014-09-29 20:48:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 812400928dc858faec61ac4b4d96fc7a690137a2
6 years, 2 months ago (2014-09-29 23:08:56 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 23:09:54 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/16e2f2806a4e505ed1941e2720339499aebea4ea
Cr-Commit-Position: refs/heads/master@{#297297}

Powered by Google App Engine
This is Rietveld 408576698