Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 580633002: Subzero: Add rudimentary statistics on generated code. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Add rudimentary statistics on generated code. The following are collected: - Number of machine instructions emitted - Number of registers saved/restored in prolog/epilog - Number of stack frame bytes (non-alloca) allocated - Number of "spills", or stores to stack slots - Number of "fills", or loads/operations from stack slots - Fill+Spill count (sum of above two) These are somewhat reasonable approximations of code quality, and the primary intention is to compare before-and-after when trying out an optimization. The statistics are dumped after translating each function. Per-function and cumulative statistics are collected. The output lines have a prefix that is easy to filter. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1873560a5b49434905d52460532c7fcce9b7e6de

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove SpillsPlusFills and calculate as Spills+Fills #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -3 lines) Patch
M src/IceCfgNode.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M src/IceClFlags.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/IceGlobalContext.h View 1 3 chunks +55 lines, -0 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/IceInst.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/IceInstX8632.h View 3 chunks +11 lines, -1 line 0 comments Download
M src/IceTargetLoweringX8632.cpp View 3 chunks +9 lines, -0 lines 0 comments Download
M src/IceTranslator.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/llvm2ice.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
6 years, 3 months ago (2014-09-16 23:58:43 UTC) #2
jvoung (off chromium)
LGTM https://codereview.chromium.org/580633002/diff/1/src/IceCfgNode.cpp File src/IceCfgNode.cpp (right): https://codereview.chromium.org/580633002/diff/1/src/IceCfgNode.cpp#newcode488 src/IceCfgNode.cpp:488: if (uint32_t Count = (*I)->getEmitInstCount()) { At some ...
6 years, 3 months ago (2014-09-17 01:21:12 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/580633002/diff/1/src/IceGlobalContext.h File src/IceGlobalContext.h (right): https://codereview.chromium.org/580633002/diff/1/src/IceGlobalContext.h#newcode55 src/IceGlobalContext.h:55: Str << "|" << Name << "|Spills+Fills|" << SpillsPlusFills ...
6 years, 3 months ago (2014-09-17 02:57:06 UTC) #4
Jim Stichnoth
6 years, 3 months ago (2014-09-17 02:59:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 1873560 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698