Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: components/gcm_driver/gcm_account_mapper.cc

Issue 580603002: [GCM] Adding registration ID request and tests to GCM Account Mapper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing CR feedback Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_account_mapper.h ('k') | components/gcm_driver/gcm_account_mapper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_account_mapper.cc
diff --git a/components/gcm_driver/gcm_account_mapper.cc b/components/gcm_driver/gcm_account_mapper.cc
index 0e54fd502dd1c9882f212bbadde7ae00046555a7..9b5ccb739444d5c0b0bcf4385ae0755dcf4af228 100644
--- a/components/gcm_driver/gcm_account_mapper.cc
+++ b/components/gcm_driver/gcm_account_mapper.cc
@@ -47,22 +47,26 @@ GCMAccountMapper::~GCMAccountMapper() {
}
void GCMAccountMapper::Initialize(
- const std::vector<AccountMapping>& account_mappings,
- const std::string& registration_id) {
+ const std::vector<AccountMapping>& account_mappings) {
DCHECK(!initialized_);
initialized_ = true;
- registration_id_ = registration_id;
-
accounts_ = account_mappings;
-
gcm_driver_->AddAppHandler(kGCMAccountMapperAppId, this);
-
- // TODO(fgorski): if no registration ID, get registration ID.
+ GetRegistration();
}
void GCMAccountMapper::SetAccountTokens(
const std::vector<GCMClient::AccountTokenInfo> account_tokens) {
- DCHECK(initialized_);
+ // If account mapper is not ready to handle tasks yet, save the latest
+ // account tokens and return.
+ if (!IsReady()) {
+ pending_account_tokens_ = account_tokens;
+ // If mapper is initialized, but still does not have registration ID,
+ // maybe the registration gave up. Retrying in case.
+ if (initialized_)
+ GetRegistration();
+ return;
+ }
// Start from removing the old tokens, from all of the known accounts.
for (AccountMappings::iterator iter = accounts_.begin();
@@ -214,6 +218,10 @@ bool GCMAccountMapper::CanHandle(const std::string& app_id) const {
return app_id.compare(kGCMAccountMapperAppId) == 0;
}
+bool GCMAccountMapper::IsReady() {
+ return initialized_ && !registration_id_.empty();
+}
+
void GCMAccountMapper::SendAddMappingMessage(AccountMapping& account_mapping) {
CreateAndSendMessage(account_mapping);
}
@@ -257,7 +265,6 @@ void GCMAccountMapper::CreateAndSendMessage(
account_mapping.account_id));
}
-
void GCMAccountMapper::OnSendFinished(const std::string& account_id,
const std::string& message_id,
GCMClient::Result result) {
@@ -280,6 +287,29 @@ void GCMAccountMapper::OnSendFinished(const std::string& account_id,
gcm_driver_->UpdateAccountMapping(*account_mapping);
}
+void GCMAccountMapper::GetRegistration() {
+ DCHECK(registration_id_.empty());
+ std::vector<std::string> sender_ids;
+ sender_ids.push_back(kGCMAccountMapperSenderId);
+ gcm_driver_->Register(kGCMAccountMapperAppId,
+ sender_ids,
+ base::Bind(&GCMAccountMapper::OnRegisterFinished,
+ weak_ptr_factory_.GetWeakPtr()));
+}
+
+void GCMAccountMapper::OnRegisterFinished(const std::string& registration_id,
+ GCMClient::Result result) {
+ if (result == GCMClient::SUCCESS)
+ registration_id_ = registration_id;
+
+ if (IsReady()) {
+ if (!pending_account_tokens_.empty()) {
+ SetAccountTokens(pending_account_tokens_);
+ pending_account_tokens_.clear();
+ }
+ }
+}
+
bool GCMAccountMapper::CanTriggerUpdate(
const base::Time& last_update_time) const {
return last_update_time +
« no previous file with comments | « components/gcm_driver/gcm_account_mapper.h ('k') | components/gcm_driver/gcm_account_mapper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698